Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update consensus information #199

Merged
merged 9 commits into from
Mar 10, 2022

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Mar 7, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Update consensus info, including:

  • Add clear recommendation of QBFT to appropriate places, and clarify what's supported.
  • Reorder pages to prioritize QBFT.
  • Minor edits across consensus pages.
  • Add migration info for Clique.

Issue fixed

fixes https://github.com/ConsenSys/protocol-misc/issues/576
fixes #198

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@alexandratran alexandratran requested a review from a team as a code owner March 7, 2022 20:57
@alexandratran alexandratran temporarily deployed to preview March 7, 2022 20:57 Inactive
@alexandratran alexandratran temporarily deployed to preview March 7, 2022 23:38 Inactive
@alexandratran alexandratran temporarily deployed to preview March 7, 2022 23:51 Inactive
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback

docs/concepts/consensus/comparing-poa.md Outdated Show resolved Hide resolved
docs/concepts/consensus/overview.md Outdated Show resolved Hide resolved
@alexandratran alexandratran temporarily deployed to preview March 8, 2022 18:21 Inactive
@alexandratran alexandratran temporarily deployed to preview March 8, 2022 18:25 Inactive
@alexandratran alexandratran temporarily deployed to preview March 8, 2022 18:25 Inactive
@alexandratran alexandratran requested review from bgravenorst and a team March 8, 2022 18:31
@alexandratran alexandratran temporarily deployed to preview March 9, 2022 07:05 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran temporarily deployed to preview March 10, 2022 18:28 Inactive
@alexandratran alexandratran merged commit c0a1746 into Consensys:main Mar 10, 2022
@alexandratran alexandratran temporarily deployed to no-secret March 10, 2022 19:42 Inactive
@alexandratran alexandratran deleted the 576-clarify-consensus branch March 10, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "proof of X" usage consistent
3 participants