This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Fix modal title overflow + ember-keyboard dep #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test coverage: 92.33% 🚨 No before coverage could be loaded |
jmar910
force-pushed
the
james/fix-modal-title-overflow
branch
from
ffcb87a to
b1753ba
Compare
jayjayjpg
approved these changes
Sep 21, 2022
| @@ -34,7 +34,7 @@ | |||
| {{#if @title}} | |||
| <h2 | |||
| id={{this.titleId}} | |||
| class="text-gray-900 font-semibold text-2xl mb-8" | |||
| class="text-gray-900 font-semibold text-2xl mb-8 overflow-hidden text-ellipsis" | |||
There was a problem hiding this comment.
Nice catch, thank you for adding this! ✨
| @@ -39,7 +39,7 @@ | |||
| "dependencies": { | |||
| "ember-cli-babel": "^7.26.10", | |||
| "ember-cli-htmlbars": "^5.7.2", | |||
| "ember-keyboard": "7.0.1", | |||
| "ember-keyboard": "6.0.4", | |||
There was a problem hiding this comment.
Great catch as well, thank you for the update!
jmar910
changed the title
|
Test coverage: 92.33% 🚨 No before coverage could be loaded |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback ember-keyboard to an earlier version that supports ember 3 -- See https://github.com/adopted-ember-addons/ember-keyboard#compatibility
Fixes modal title overflow in mxa components for Conduit