This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
feat(mox/link-button): add new link-button component #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5f4b4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Test coverage: 92.37% 🤷♂️ Did not change |
|
@jmar910 I may also add these two component updates to the library this week in follow-up PRs:
Does it make sense to add these changes first before adding a changeset or would you prefer if I already added one to this and the other subsequent PRs? Happy to go with either! |
|
Test coverage: 92.37% 🤷♂️ Did not change |
samirketema
approved these changes
Jul 6, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/meroxa/platform-ui-v1/issues/988
With this change, we're adding a new
Mox::LinkButtoncomponent to the component library. The component is both dark and light mode capable. This way, we can already integrate its dark mode variant into the dashboard today.Screens