Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add pipelines describe command #2078

Merged
merged 14 commits into from
Jan 17, 2025
Merged

CLI: Add pipelines describe command #2078

merged 14 commits into from
Jan 17, 2025

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Jan 16, 2025

Description

Closes #2020.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review January 16, 2025 18:35
@hariso hariso requested a review from a team as a code owner January 16, 2025 18:35
cmd/conduit/root/pipelines/describe.go Outdated Show resolved Hide resolved
cmd/conduit/root/pipelines/describe.go Outdated Show resolved Hide resolved
cmd/conduit/root/pipelines/describe.go Outdated Show resolved Hide resolved
cmd/conduit/root/pipelines/describe.go Outdated Show resolved Hide resolved
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariso looking great! Just some minor comments (+what @maha-hajja already caught)

cmd/conduit/root/pipelines/describe.go Show resolved Hide resolved
cmd/conduit/root/pipelines/describe.go Show resolved Hide resolved
examples/pipelines/file-to-file.yaml Show resolved Hide resolved
examples/pipelines/multiple-destinations.yaml Show resolved Hide resolved
examples/pipelines/pipeline-with-dlq.yaml Outdated Show resolved Hide resolved
@hariso hariso requested review from maha-hajja and raulb January 17, 2025 09:58
@hariso hariso enabled auto-merge (squash) January 17, 2025 14:16
@hariso hariso merged commit 582be55 into main Jan 17, 2025
3 checks passed
@hariso hariso deleted the haris/cli-pipelines-describe branch January 17, 2025 15:00
@raulb
Copy link
Member

raulb commented Jan 17, 2025

@hariso noticed some issues here that I'm fixing on #2082.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: conduit pipelines describe ID
4 participants