Samir/block rebalance on poll #155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirketema
commented
Jul 11, 2024
Comment on lines
+84
to
+87
| for c.acker.curBatchIndex != 0 { | ||
| sdk.Logger(ctx).Warn().Msgf("partitions revoked or lost, waiting until current batch of records are acked and committed...") | ||
| time.Sleep(50 * time.Millisecond) | ||
| } |
There was a problem hiding this comment.
One concern is that we want to make sure that the current batch of records were acked, so we can go ahead and commit them, then continue processing - this currently loops infinitely, as some records aren't acked. Need to continue debugging.
In general, this is aimed to help prevent duplicates. But if we are okay with at-least-once processing, then, we don't need to implement OnPartitionsRevoked / OnPartitionsLost: https://pkg.go.dev/github.com/twmb/franz-go/pkg/kgo#Client.CommitRecords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Experimenting with
BlockRebalanceOnPollfranz consumer configFixes # (issue)
Quick checks: