Add new method for vacuuming a c1z db. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstanbCO
reviewed
Oct 19, 2023
| return err | ||
| } | ||
|
|
||
| c.dbUpdated = true |
There was a problem hiding this comment.
Do you need to set this to true here, when it is already set from the vacuum call?
There was a problem hiding this comment.
In practice no, but i think it is probably good to set it in any method that changes the database. This flag being set to true is what tells the c1z manager that it should write the c1z back to the origin. There isn't really a way to run this method without invoking other things that change the database, but for completeness sake I'm setting it.
mstanbCO
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vacuum after removing old generations of data.
Without this vacuuming, the c1z database will continue to grow in size even though we are removing old data. Vacuuming allows us to reclaim the space used by previous generations, keeping the decompressed file size as small as expected.