Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny: We don't need to Close() the underlying reader if we never initialized it by calling Read(). #109

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Tiny: We don't need to Close() the underlying reader if we never initialized it by calling Read(). #109

merged 1 commit into from
Feb 27, 2024

Conversation

morgabra
Copy link
Contributor

We don't initialize underlying decoder until we call Read() the first time, so don't try to close a nil decoder if we never Read() from one.

@morgabra morgabra requested a review from jirwin as a code owner February 27, 2024 19:18
@ggreer ggreer merged commit 29e6ac0 into main Feb 27, 2024
4 checks passed
@ggreer ggreer deleted the morgabra/decoder_close_after_init branch February 27, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirwin jirwin jirwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morgabra @jirwin @ggreer