Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): bump node #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(security): bump node #19

wants to merge 2 commits into from

Conversation

quinnjn
Copy link

@quinnjn quinnjn commented Sep 14, 2022

Bumps node12 to node16. Also suggesting at least node 16 for install. Node 12 is EOL.

Review Checklist

PR titles must follow the type: description format. See Conventional Commits for a summary and examples.

Please complete these steps before requesting code review:

  • This PR provides a description, testing steps, and adequate context for reviewers
  • Unit tests added/updated to provide coverage for functional code changes in this PR

Copy link
Collaborator

@mattbedell mattbedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current LTS is 18.12.1, I think we can bump to 18 now

anayeaye added a commit to NASA-IMPACT/veda-backend that referenced this pull request Nov 27, 2023
- Upgrade to github actions to resolve outdated node version warnings
- Add cdk deploy output to file to resolve set-output warning
- Conventional PR linter if not not updated: we may need to remove or
replace if this [upgrade
PR](CondeNast/conventional-pull-request-action#19)
is not accepted. For now, there is a warning in the pr action about
forcing linter to run on an upgraded node version.

Parent issue NASA-IMPACT/veda-architecture#345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants