Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useDataSet hook in the react renderer #1813

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

colin-alexa
Copy link
Contributor

adds a hook to the @atjson/react renderer package that allows components to access datasets (by id) on the current document while rendering. Something like this is necessary to support tables and other dataset visualization objects

@colin-alexa colin-alexa requested a review from tim-evans October 21, 2024 22:08
Copy link
Collaborator

@tim-evans tim-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@colin-alexa colin-alexa merged commit 2d7387a into main Oct 23, 2024
3 checks passed
@colin-alexa colin-alexa deleted the react-dataset-hook branch October 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants