feat: properly store post content on social media blocks #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-evans
force-pushed
the
attribute-standardization
branch
from
be28e1b to
91fbe8c
Compare
tim-evans
force-pushed
the
social-media-content
branch
from
cfe433d to
f88d980
Compare
bachbui
reviewed
Jun 5, 2024
| let content = slice | ||
| ? this.render(slice) | ||
| : `<a target="_blank" title="@vogueitalia" href="https://www.tiktok.com/${username}">${username}</a>`; | ||
| : `<a target="_blank" title="${username}" href="https://www.tiktok.com/${username}">${username}</a>`; |
bachbui
reviewed
Jun 5, 2024
| cite: embed.attributes.url, | ||
| }).join(" ")}>${this.render(slice)}</blockquote></div>`; | ||
| } else { | ||
| return `<iframe ${[ |
There was a problem hiding this comment.
Would it not make sense to still render the same structure as the above, just without the <blockquote> element (or with an empty <blockquote> element)?
this aligns with React PropTypes boolean naming conventions in cases where the block is being rendered directly to React
dkorenblyum
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-on to #1685, I'm properly setting the
contentproperty of social media embeds to the textual content included on them, which allows some basic understanding of what the post was at the time of embedding, which is useful for journalistic reasons.For legibility reasons, I've separated conversions for the HTML source into separate files so there is individual files responsible for testing each annotation.
So for a TwitterEmbed (yes, sorry), we may get an embedded post (below), that was throwing away the textual contents.
Now this will be stored as text on the
contentproperty:{ "blocks": [ { "attributes": { "content": "M00000000", "url": "https://twitter.com/Pokemon/status/1227294189185949696", }, "id": "B00000000", "parents": [], "selfClosing": false, "type": "twitter-embed", }, { "attributes": {}, "id": "B00000001", "parents": [ "twitter-embed", ], "selfClosing": false, "type": "text", } ], "marks": [ { "attributes": { "refs": [ "B00000000", ], }, "id": "M00000000", "range": "(1..92]", "type": "slice", }, { "attributes": { "url": "https://t.co/f5OF4ikSFj", }, "id": "M00000001", "range": "(27..53)", "type": "link", }, { "attributes": { "url": "https://twitter.com/Pokemon/status/1227294189185949696?ref_src=twsrc^tfw", }, "id": "M00000002", "range": "(75..92)", "type": "link", }, ], "text": "Respect the drip, twerp. pic.twitter.com/f5OF4ikSFj— Pokémon (@Pokemon) February 11, 2020", }