feat(CNE-10708): add CNE Ticketing Widget #1705
Conversation
| url: string; | ||
| }> { | ||
| static vendorPrefix = "offset"; | ||
| static type = "cne-ticketing-widget-embed"; |
There was a problem hiding this comment.
We've been going back and forth on naming. For sure I think we don't need widget in the annotation name. Perhaps
cne-event-registration-embed or cne-swoogo-embed ?
There was a problem hiding this comment.
@bachbui We prefer cne-event-registration-embed
code to insert into CKeditor in copilot
<cne-event-registration url="https://baseurl?loggedout=loggedouturlslug&loggedin=loggedinslug&privacy=true"></cne-event-registration>
markdown
[#cneeventregistration: https://baseurl?loggedout=loggedouturlslug&loggedin=loggedinslug&privacy=true]
embed
<cne-event-registration-embed url="https://baseurl?loggedout=loggedouturlslug&loggedin=loggedinslug&privacy=true"></cne-event-registration-embed>
Is that okay? I wait for a response before proceeding with the changes (file names, classes, tests, etc.)
There was a problem hiding this comment.
@bachbui rename cne-ticketing-widget to cne-event-registration
Let me know if everything is correct.
| }, | ||
| }) | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Just a note - the purpose for this is only to support a conversion from this kind of contrived html snippet. If in the future users would have a different way of producing this kind of embed (for example, perhaps in a rich-text environment rather than inserting via an embed code, the user would have a form to enter in the loggedIn/loggedOut URLs and privacy flag) then we could remove this
| @@ -214,6 +215,22 @@ export default function convertThirdPartyEmbeds(doc: Document) { | |||
| }) | |||
| ); | |||
| }); | |||
| /** | |||
| * CNE Ticketing Widget | |||
| */ | |||
There was a problem hiding this comment.
Can we please update this comment to describe what this HTML structure is? IE, this is a custom HTML element used to describe an event registration block with a specific URL, with some specific metadata encoded in the URL
There was a problem hiding this comment.
I'll add a short description, thanks
There was a problem hiding this comment.
Updated comment with a short description
Add CNE Ticketing Widget
code to insert into CKeditor in copilot
<cne-ticketing-widget url="https://baseurl?loggedout=loggedouturlslug&loggedin=loggedinslug&privacy=true"></cne-ticketing-widget>markdown
[#cneticketingwidget: https://baseurl?loggedout=loggedouturlslug&loggedin=loggedinslug&privacy=true]embed
<cne-ticketing-widget-embed url="https://baseurl?loggedout=loggedouturlslug&loggedin=loggedinslug&privacy=true"></cne-ticketing-widget-embed>