feat: api for rating #542
Merged
feat: api for rating #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RadioNoiseE is attempting to deploy a commit to the qwerzl Team on Vercel. A member of the Team first needs to authorize it. |
|
Before writing into the database, you should check if there's any record of a same user, same scope and same club. Return 403 if there is already one. |
qwerzl
requested changes
Mar 25, 2024
server/api/club/rating/new.post.ts
Outdated
| club: z.string(), | ||
| date: z.string().datetime(), | ||
| score: z.number().lte(5), | ||
| comment: z.string(), |
server/api/club/rating/new.post.ts
Outdated
| date: z.string().datetime(), | ||
| score: z.number().lte(5), | ||
| comment: z.string(), | ||
| scope: z.string(), |
server/api/club/rating/new.post.ts
Outdated
| return | ||
| } | ||
|
|
||
| const requestBody = await readValidatedBody(event, body => requestSchema.safeParse(body)) |
There was a problem hiding this comment.
Just use requestSchema.parse(), so it will automatically return a validation error if validation is not success.
server/api/club/rating/new.post.ts
Outdated
| } | ||
|
|
||
| const requestBody = await readValidatedBody(event, body => requestSchema.safeParse(body)) | ||
| if (requestBody.success) { |
There was a problem hiding this comment.
So you don't need this if here.
There was a problem hiding this comment.
Also, check if requestSchema.scope equals to the current scope. If not, return 403.
There was a problem hiding this comment.
Change rateable to available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.