Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clubList): show dissolved clubs at the end of clubList #537

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

at-wr
Copy link
Contributor

@at-wr at-wr commented Mar 19, 2024

It might be hard to review the code lol

Related Issue

#532

Copy link

vercel bot commented Mar 19, 2024

@at-wr is attempting to deploy a commit to the qwerzl Team on Vercel.

A member of the Team first needs to authorize it.

@at-wr at-wr changed the title feat(clubList): show dissolved clubs at the end of the list feat(clubList): show dissolved clubs at the end of clubList Mar 19, 2024
@qwerzl
Copy link
Collaborator

qwerzl commented Mar 19, 2024

It might be better to just sort the club before filteredClubs is defined. Define a custom sort function, then club.sort(someCustomSortFunc). Check this out: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort.

edit: sorry didn't notice you've already used .sort(). Still, it's better to directly sort club. @at-wr

@at-wr
Copy link
Contributor Author

at-wr commented Mar 19, 2024

It might be better to just sort the club before filteredClubs is defined. Define a custom sort function, then club.sort(someCustomSortFunc). Check this out: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort.

edit: sorry didn't notice you've already used .sort(). Still, it's better to directly sort club. @at-wr

@qwerzl Hey, I defined a new function sortClubs and simplified the searching logic which can also optimize the performance

@qwerzl
Copy link
Collaborator

qwerzl commented Mar 21, 2024

@at-wr Fixed some code. Always remember not to use any type, not to assign redundant variables and not to copy-paste from GPT. But well done in general.

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
enspire ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 1:42pm

@qwerzl qwerzl merged commit 0ed03d3 into Computerization:next Mar 21, 2024
5 checks passed
@qwerzl
Copy link
Collaborator

qwerzl commented Mar 21, 2024

Closes #532.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants