Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(club): adjusting display logic for various conditions #531

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

at-wr
Copy link
Contributor

@at-wr at-wr commented Mar 12, 2024

Fixed Issues

  • (In Club Card) Does not show Globe Icon if a certain club's English name does not exist
  • (In Club Page) Show Club Description instead of empty spaces if a certain club's English name does not exist
  • (In Club Page) Do not show brackets if a certain student's English name does not exist
  • (In Club Page) Does not show 指导老师 if a certain club does not have any supervisor

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for computerization-enspire-next ready!

Name Link
🔨 Latest commit 6a3554f
🔍 Latest deploy log https://app.netlify.com/sites/computerization-enspire-next/deploys/65f2fd561ecfe300081043cc
😎 Deploy Preview https://deploy-preview-531--computerization-enspire-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@at-wr at-wr changed the title fix: minor fixes of adjusting display logic for various conditions fix: adjusting display logic for various conditions Mar 12, 2024
@at-wr at-wr changed the title fix: adjusting display logic for various conditions fix(club): adjusting display logic for various conditions Mar 12, 2024
pages/cas/clubs/[id].vue Outdated Show resolved Hide resolved
@qwerzl
Copy link
Collaborator

qwerzl commented Mar 14, 2024

Changed a little bit:

  • "简介“ and "成员列表” are now in text-sm.
  • Height of badges are now reduced by 0.5
  • Removed “社员” badges, looks a bit too crowded with them.

@qwerzl qwerzl merged commit dba9745 into Computerization:next Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants