shift AtomicConfigNumber to standard unit tests #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: picongpu
BrianMarre
force-pushed
the
topic-moveAtomicPhysicsUnittestToCIUnitTests
branch
from
1890c3e to
5ddb8f9
Compare
psychocoderHPC
added
refactoring
psychocoderHPC
approved these changes
Oct 21, 2024
chillenzer
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
As planned, this is not yet properly integrated into Catch2 and I believe to leverage its full potential, we should do so at some point. I have opened #5186 to track this.
chillenzer
merged commit 6347d31
into
ComputationalRadiationPhysics:dev
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves the atomicConfigNumber unit test of FLYonPIC from it's custom location to the standard unit test folder of PIConGPU and makes it part of the the unit test suite of PIConGPU.
@attention This PR removes the
picongpu::configNumber::RUN_UNIT_TESToption in theatomicPhysics_Debug.paramfile. Old setups setting with this option will still work, but any setting of the option will be ignored.If you want to run this test, use the PIConGPU unit test framework instead.
ci: picongpu