PIConGPU: complete header check #5167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
added
the
refactoring
chillenzer
previously approved these changes
Oct 11, 2024
| file(GLOB_RECURSE PIC_FRAME_TRAITS "${PIC_SUFFIXED_INCLUDE_DIR}/traits/frame/*.hpp") | ||
| list(REMOVE_ITEM PIC_FILES_HEADER ${PIC_ATTRIBUTE_TRAITS}) | ||
| list(REMOVE_ITEM PIC_FILES_HEADER ${PIC_FRAME_TRAITS}) | ||
| append_recursive_files("${PIC_SUFFIXED_INCLUDE_DIR}/." "hpp" "PIC_FILES_HEADER") | ||
|
|
There was a problem hiding this comment.
Isn't it beautiful how it all falls in place?
psychocoderHPC
force-pushed
the
topic-includeRefactoring2
branch
3 times, most recently
from
69e4da0 to
ad0338d
Compare
- add `fields` and `particle` header check - fix missing includes and resolve cyclic includes ci: picongpu
psychocoderHPC
force-pushed
the
topic-includeRefactoring2
branch
from
ad0338d to
ab9f1aa
Compare
|
You made it pass! =) |
chillenzer
approved these changes
Oct 16, 2024
chillenzer
merged commit ea615f3
into
ComputationalRadiationPhysics:dev
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: The header check is running without optional dependencies e.g openPMD, fftw3 or pngwriter. This will be addressed after the release.