Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from mamba to uv #5082

Closed
wants to merge 1 commit into from
Closed

Switch from mamba to uv #5082

wants to merge 1 commit into from

Conversation

chillenzer
Copy link
Contributor

#5077 seems to have been insufficient.

@chillenzer chillenzer added component: tools scripts, python libs and CMake bug a bug in the project's code component: tests unit tests and removed component: tools scripts, python libs and CMake labels Sep 9, 2024
psychocoderHPC
psychocoderHPC previously approved these changes Sep 9, 2024
View reviewed changes
@psychocoderHPC psychocoderHPC added this to the 0.8.0 / Next stable milestone Sep 9, 2024
@BrianMarre
Copy link
Member

BrianMarre commented Sep 9, 2024 •
edited
Loading

PyPIConGPU test fails, might have something to do with this setting

picongpu/.gitlab-ci.yml

Line 184 in 89b9640

PYTHON_VERSION: '3.11.*'

@psychocoderHPC
Copy link
Member

PyPIConGPU test fails, might have something to do with this setting

picongpu/.gitlab-ci.yml

Line 184 in 89b9640

PYTHON_VERSION: '3.11.*'

@chillenzer I stopped the CI because this must be fixed

@chillenzer
Copy link
Contributor Author

Thanks for pointing this out. As far as I can see it, the syntax .* is not supported by uv for selecting a Python version. Pushed an update. Btw, why aren't we on 3.12?

@BrianMarre
Copy link
Member

Because when we built the PyPIConGPU CI Python 3.12 wasn't out yet

@psychocoderHPC
Copy link
Member

I stopped the CI again because of errors https://gitlab.com/hzdr/crp/picongpu/-/jobs/7785698774

@psychocoderHPC psychocoderHPC added the CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests label Sep 10, 2024
@psychocoderHPC
Copy link
Member

picongpu/share/ci/pypicongpu_generator.py

Line 327 in 817b9eb

"PYTHON_VERSION": pyVer + ".*",

is adding .* to the version number

@chillenzer
Copy link
Contributor Author

Nasty. I have now also run grep -ri "python" share and grep -r '\.\* share with no further results.

PrometheusPi
PrometheusPi requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@PrometheusPi PrometheusPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment correction

share/ci/install/pypicongpu.sh
@@ -27,20 +27,14 @@ cd $CI_PROJECT_DIR
# use miniconda as python environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is now outdated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll remove it once the CI passed such that we can merge without another CI run.

@psychocoderHPC
Copy link
Member

It looks like it is not as simple as it sounds to switch the package manager for python.
Let's evaluate if we go on with the switch or stay with micromambda. For now, it looks like IT solved the issues by updating their black list.

@chillenzer
Copy link
Contributor Author

Apparently, IT has fixed the problem with mamba which makes this change unnecessary. Also, we have snakemake workflows which would make it particularly inconvenient to leave mamba completely. So, we'll close this PR for now.

PS: The failing CI probably just needs a renaming pip3 -> [uv ]pip (not sure if we'd need/want uv in front there).

@chillenzer chillenzer closed this Sep 11, 2024
@chillenzer chillenzer mentioned this pull request Sep 11, 2024
Open
@BrianMarre
Copy link
Member

For future reference, Simeon recommended to switch to tox to simplify the PyPIConGPU generator, since tox apparently provides a native way to fix software versions for CI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrometheusPi PrometheusPi PrometheusPi requested changes

@psychocoderHPC psychocoderHPC psychocoderHPC left review comments

Assignees
No one assigned
Labels
bug a bug in the project's code CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests component: tests unit tests
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chillenzer @BrianMarre @psychocoderHPC @PrometheusPi