Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIConGPU unit tests #4723

Merged
merged 2 commits into from
Nov 13, 2023
Merged

PIConGPU unit tests #4723

merged 2 commits into from
Nov 13, 2023

Conversation

psychocoderHPC
Copy link
Member

@psychocoderHPC psychocoderHPC commented Oct 25, 2023 •
edited
Loading

  • add units tets for PIConGPU
    • build the first test case to check particle shapes
  • call unit tests in the CI
  • remove unused trait GetDataBoxType
  • cleanup include to avoid pulling full PIConGPU within shape tests
  • cleanup includes in simulation_types.hpp and simulation_defines.hpp

@psychocoderHPC psychocoderHPC added component: core in PIConGPU (core application) component: tests unit tests labels Oct 25, 2023
@psychocoderHPC psychocoderHPC added this to the 0.8.0 / Next stable milestone Oct 25, 2023
@psychocoderHPC psychocoderHPC force-pushed the topic-picongpuUnitTests branch 4 times, most recently from 83ae52b to 5fc5360 Compare October 25, 2023 13:54
@psychocoderHPC psychocoderHPC changed the title add picongpu unit tests PIConGPU unit tests Oct 25, 2023
@psychocoderHPC psychocoderHPC force-pushed the topic-picongpuUnitTests branch 5 times, most recently from 41117a5 to 9d1619e Compare October 25, 2023 15:29
@psychocoderHPC psychocoderHPC marked this pull request as ready for review October 25, 2023 17:48
@steindev steindev added the changelog PR's marked with this label will be added to the changelog label Oct 26, 2023
PrometheusPi
PrometheusPi previously approved these changes Nov 1, 2023
View reviewed changes
include/picongpu/particles/Particles.hpp Show resolved Hide resolved
include/picongpu/traits/GetDataBoxType.hpp Outdated Show resolved Hide resolved
share/ci/backendFlags.sh Show resolved Hide resolved
share/ci/run_picongpu_unit_tests.sh Outdated Show resolved Hide resolved
share/picongpu/unit/shape.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool test, a bit more comments would help me better understand what is going on. (but not needed)

@psychocoderHPC
cleanup to support unit tests
65bfe33 
- remove unused trait `GetDataBoxType`
- cleanup include to avoid pulling full PIConGPU within shape tests
- cleanup includes in simulation_types.hpp and simulation_defines.hpp
@psychocoderHPC psychocoderHPC force-pushed the topic-picongpuUnitTests branch from 9d1619e to 8ee06dd Compare November 8, 2023 09:23
@psychocoderHPC
Copy link
Member Author

I pushed the changes,

PrometheusPi
PrometheusPi requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@PrometheusPi PrometheusPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I found another typo

share/picongpu/unit/shape.cpp Outdated Show resolved Hide resolved
@psychocoderHPC
PIConGPU units tests
d4d6939 
- add units tets for PIConGPU
  - build first test case to check particle shapes
- call unit tests in the CI
@psychocoderHPC psychocoderHPC force-pushed the topic-picongpuUnitTests branch from 8ee06dd to d4d6939 Compare November 8, 2023 10:42
@psychocoderHPC psychocoderHPC merged commit 7916ed6 into ComputationalRadiationPhysics:dev Nov 13, 2023
2 checks passed
@psychocoderHPC psychocoderHPC deleted the topic-picongpuUnitTests branch November 13, 2023 16:36
@psychocoderHPC psychocoderHPC mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrometheusPi PrometheusPi PrometheusPi approved these changes

@ikbuibui ikbuibui Awaiting requested review from ikbuibui

@steindev steindev Awaiting requested review from steindev

Assignees
No one assigned
Labels
changelog PR's marked with this label will be added to the changelog component: core in PIConGPU (core application) component: tests unit tests
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@psychocoderHPC @PrometheusPi @steindev