Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/lambda #42

Merged
merged 2 commits into from
Sep 5, 2013
Merged

Fix/lambda #42

merged 2 commits into from
Sep 5, 2013

Conversation

heikoburau
Copy link
Member

Fix Lambda

  • Pass References instead of Values

@ax3l
Copy link
Member

ax3l commented Sep 5, 2013

Looks good, just waiting for the compile test to prove everything is all right.

@psychocoderHPC
Copy link
Member

Is it possible that you get now problems with creation of && (reference on refernces). http://stackoverflow.com/questions/5590978/reference-of-reference-in-c.
I am not sure.

@heikoburau
Copy link
Member Author

Not is this case, because it is guaranteed that ArgN is no reference type.

@heikoburau
Copy link
Member Author

Do not accept yet!

Heikman added 2 commits September 5, 2013 15:01
fix lambda lib
bfe6555 
- make_Functor.hpp: store references instead of values in argTuple
- Tuple.hpp: add a contructor which accepts non-const references
make PIConGPU incompatible to sm_13
54a0bfb 
- change every occurence of sm_13 to sm_20
@heikoburau
Copy link
Member Author

ready to pull. Be aware: By approving this pull request YOU make PIConGPU incompatible to sm_13

@heikoburau
Copy link
Member Author

sm_13 causes an "internal nvopencc error" with this branch

@PrometheusPi
Copy link
Member

Is compatibility with sm_13 still necessary?
How many systems are not able to run with sm_20?

@ax3l
Copy link
Member

ax3l commented Sep 5, 2013

We already agreed with Michael on abandoning sm_13 when it becomes necessary.
RIP sm_13 :shipit:

Ha: that means you have to commit totally warning-free code from now on ^^

@PrometheusPi
Copy link
Member

That's great!

@ax3l
Copy link
Member

ax3l commented Sep 5, 2013

So merge it ;)

PrometheusPi added a commit that referenced this pull request Sep 5, 2013
@PrometheusPi
Merge pull request #42 from Heikman/fix/Lambda
eef746a 
Fix/lambda - merged
RIP sm_13
@PrometheusPi PrometheusPi merged commit eef746a into ComputationalRadiationPhysics:dev Sep 5, 2013
@ghost ghost assigned heikoburau Sep 5, 2013
@ax3l ax3l mentioned this pull request Oct 2, 2013
Closed
ax3l pushed a commit to ax3l/picongpu that referenced this pull request Feb 17, 2015
@psychocoderHPC
Merge pull request ComputationalRadiationPhysics#42 from slizzered/ge…
a729b57 
…t_available_slots_unified

unified interface to getAvailableSlots
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this pull request Sep 7, 2023
@psychocoderHPC
Squashed 'thirdParty/cuda_memtest/' changes from dd723aad67..025bc92c4f
97186a9 
025bc92c4f Merge pull request ComputationalRadiationPhysics#44 from psychocoderHPC/fix-warningIgnoredReturnType
379bfff87f fix warning `unused return value`
c3348b7f0f Merge pull request ComputationalRadiationPhysics#42 from chengweiv5/fix-typo-in-README
18ff10afd3 README: fix typo
143289d880 Merge pull request ComputationalRadiationPhysics#40 from psychocoderHPC/topic-useRpath
aa36001343 use RPATH by default

git-subtree-dir: thirdParty/cuda_memtest
git-subtree-split: 025bc92c4f92ea77c513c010867ca41353c03032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heikoburau heikoburau

Labels
bug a bug in the project's code
Projects
None yet
Milestone
0.2.0: Open Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@heikoburau @ax3l @psychocoderHPC @PrometheusPi