Update example .param files with src tree #384

f-schmitt · 2014-04-30T08:00:25Z

Issue #145
Fixes most param files, except radiationObserver as those had pretty significant changes.

f-schmitt · 2014-04-30T08:01:07Z

@PrometheusPi maybe you want to have a look, too

PrometheusPi · 2014-04-30T08:07:48Z

@f-schmitt-zih Thanks for informing me. I overlooked this issue.

I will have a look at it during the next coffee break (10:20-10:50 CET).

ax3l · 2014-04-30T08:25:38Z

examples/Bunch/include/simulation_defines/param/gasConfig.param

@@ -101,8 +101,8 @@ namespace picongpu
        namespace SI
        {
            /** Parameters for the exponential slope
-             *  For Y > GAS_Y_MAX_SI:


I think that was right, GAS_Y_MAX_SI is defined above.

Ok, I'll revert those

PrometheusPi · 2014-04-30T08:59:20Z

@f-schmitt-zih Thank you for your work. These adjustments are great. I anotated some minor things, mainly that the observer comments have to be different for each example since the layout differes.

But again: great job 👍 .

PrometheusPi · 2014-04-30T09:05:18Z

examples/SingleParticleRadiationWithLaser/include/simulation_defines/param/laserConfig.param

-
-/** unit: Volt /meter */
-//const double AMPLITUDE_SI = _A0 * UNITCONV_A0_to_Amplitude_SI;
-


Criticism on a high level again:
I would prefere the _A0 setup, which is commented out here, to stay in in order to make changes from an AMPLITUDE_SI direct setup to an _A0 indirect setup possible without the need to copy code from another laserConfig.param file.
@ax3l what do you think?

yes @PrometheusPi is right: what looks like dead code in this .param file is actually a very quick way to specify input in 3 different ways. please leave it in.

ax3l · 2014-04-30T09:52:34Z

examples/LaserWakefield/include/simulation_defines/param/gridConfig.param

@@ -55,6 +55,8 @@ namespace picongpu
        {1.0e-3, 1.0e-3}  /*z direction [negative,positive]*/
    }; //unit: none 

+    const uint32_t ABSORBER_FADE_IN_STEPS = 16;


interesting that this did not cause a compiler error @psychocoderHPC

I think this varable is unused but I don't know why.

Ok, we will investigate that further in #390

PrometheusPi · 2014-04-30T13:22:20Z

@f-schmitt-zih: You said "except radiationObserver as those had pretty significant changes".
What do you want me to change in the radiationObserver.param files in order to fix #145?

ax3l · 2014-04-30T13:31:35Z

I think that is just the misunderstanding caused by the per-example description of the observer.

f-schmitt · 2014-04-30T13:32:24Z

I meant that most .param files differed from src by only a few comments except radiationOberser.param which had several new variables, didn't have several variables from src etc.
I don't think you need to change anything if this difference is still up-to-date.

PrometheusPi · 2014-04-30T13:42:13Z

@f-schmitt-zih Thanks for the answer.
I will then keep it that way. By that, the examples contain unique radiationObserver.param specific to the example and are written in a simpler way than the radiationObserver.param in src/.

ax3l · 2014-04-30T15:26:50Z

examples/LaserWakefield/include/simulation_defines/param/precision.param

@@ -32,10 +32,7 @@ namespace picongpu
 *  - precision64Bit : use 64Bit floating point numbers (need CUDA_ARCH>=sm_20)
 *                     [significant digits 15 to 16]
 */
-#ifndef PARAM_PRECISION


This is used in examples/LaserWakefield/cmakeFlags test 5, 6 and 10 - please revert the change.

ax3l · 2014-05-03T23:58:45Z

thanks again, well done! ✨

Update example .param files with src tree

83f3fc6 Merge pull request ComputationalRadiationPhysics#437 from BenjaminW3/topic-style-change-include-comment 6af80bf remove include comment f2cea59 Merge pull request ComputationalRadiationPhysics#416 from psychocoderHPC/topic-relaxedConstExpr 663da24 Merge pull request ComputationalRadiationPhysics#434 from psychocoderHPC/topic-addDeclvalImpl 5d36ca3 host `constexpr` within device code 1fcaf85 Do not add -G on Debug ace2059 add clang declval implementation 7543802 Merge pull request ComputationalRadiationPhysics#432 from BenjaminW3/topic-fix-MapIdx-test 61fced3 fix MapIdx test 7d0d8c5 Merge pull request ComputationalRadiationPhysics#429 from BenjaminW3/topic-fix-atomic-test 2d8a9d9 Merge pull request ComputationalRadiationPhysics#431 from ax3l/fix-deviceDebugSymbolsCUDA8GCC49 91959de Merge pull request ComputationalRadiationPhysics#430 from psychocoderHPC/fix-cudaWarning f5f73cb GCC 4.9: Do not add -G on Debug 60d881f fix CUDA warning 0f69e0a replace std::min and std::max in kernel with ternary operators cbd5db2 Merge pull request ComputationalRadiationPhysics#418 from BenjaminW3/topic-refactor-cpu-rand 6a56e8e Merge pull request ComputationalRadiationPhysics#423 from psychocoderHPC/fix-comparisonWarning 57fe354 Merge pull request ComputationalRadiationPhysics#424 from psychocoderHPC/topic-cuda9MinArchitecture 5e02bad Merge pull request ComputationalRadiationPhysics#421 from psychocoderHPC/fix-testBuildWithDynBoostLibs 6f19481 increase minimal CUDA archtitecture for CUDA 9 fd416e3 fix comparison warning in `Vec.hpp` 277a7ee fix test builds with dynamic boost lib f9e0baf factor out MersenneTwister CPU random number generator 0d4790a Merge pull request ComputationalRadiationPhysics#413 from ax3l/topic-lastTypedefs 51b3c35 Merge pull request ComputationalRadiationPhysics#412 from BenjaminW3/topic-clean-up e0bb8b0 Merge pull request ComputationalRadiationPhysics#396 from BenjaminW3/topic-events-CUDA c633d4f Remove typedef ec2b9a6 minimal clean ups 40d6b14 fix CPU event ec282a8 add event tests for CUDA 6c4c9c1 Merge pull request ComputationalRadiationPhysics#333 from BenjaminW3/topic-clang-4_0 839ee02 clang 4.0+ native CUDA 4b87306 Merge pull request ComputationalRadiationPhysics#402 from BenjaminW3/topic-OpenMP-4-clang 0112d8f fix OpenMP 4 backend for clang f1bce5e Merge pull request ComputationalRadiationPhysics#411 from ax3l/doc-noCUDAver 66201a5 Doc: No __CUDA_VER__ 2c2c216 Merge pull request ComputationalRadiationPhysics#384 from BenjaminW3/topic-cuda-9_0 e038a82 CUDA 9.0 30c94aa Merge pull request ComputationalRadiationPhysics#410 from BenjaminW3/topic-ubuntu_16_04 4e2ecf8 use newer ubuntu images in CI 476815d Merge pull request ComputationalRadiationPhysics#408 from BenjaminW3/topic-clean-up-build-logs ffe8d0b add UBSan blacklist items 986aec2 remove large file printing eb395e9 Merge pull request ComputationalRadiationPhysics#407 from BenjaminW3/topic-docker 107049d create a docker image per job and cache it 99db278 fix flaky appveyor builds aa91011 Merge pull request ComputationalRadiationPhysics#406 from BenjaminW3/topic-remove-uuid b11958f remove boost.uuid from UBSan blacklist 3cc093a rename all stream impl members to shorter and identical names for clearness 22e8aff replace comparison of underlying event/stream with comparison of impl shared_ptr ed3f89a remove uuid because it is unused 7dd080d Merge pull request ComputationalRadiationPhysics#404 from BenjaminW3/topic-kernel-unit-test-extension f5dd1a9 use the 64 bit toolset on appveyor to work around out of heap space issues 4b92e4b add kernel unit tests 0e7c221 Merge pull request ComputationalRadiationPhysics#397 from BenjaminW3/topic-refactor-travis_yml 19b0ec8 refactor .travis.yml 002b359 Merge pull request ComputationalRadiationPhysics#401 from BenjaminW3/topic-clang-5 3ab46c6 add support for clang 5 d4753f8 Merge pull request ComputationalRadiationPhysics#400 from BenjaminW3/topic-drop-clang-3_8-native-CUDA a30f1ee drop support for native CUDA compilation with clang-3.8 due to missing support of cuRand 2ed4755 Merge pull request ComputationalRadiationPhysics#386 from BenjaminW3/topic-boost-1_65 4d9e8e6 Merge pull request ComputationalRadiationPhysics#398 from psychocoderHPC/topic-hashedAtomicStlLock 7941d30 add github annotations f1f317e add support for boost-1.65 886b1ab use `AtomicStlLock<16>` fa31544 AtomicStlLock: use array of mutex git-subtree-dir: thirdParty/alpaka git-subtree-split: 83f3fc60e58a6964f03d5ce26a82569fc6456f95

7543802 Merge pull request ComputationalRadiationPhysics#432 from BenjaminW3/topic-fix-MapIdx-test 61fced3 fix MapIdx test 7d0d8c5 Merge pull request ComputationalRadiationPhysics#429 from BenjaminW3/topic-fix-atomic-test 2d8a9d9 Merge pull request ComputationalRadiationPhysics#431 from ax3l/fix-deviceDebugSymbolsCUDA8GCC49 91959de Merge pull request ComputationalRadiationPhysics#430 from psychocoderHPC/fix-cudaWarning f5f73cb GCC 4.9: Do not add -G on Debug 60d881f fix CUDA warning 0f69e0a replace std::min and std::max in kernel with ternary operators cbd5db2 Merge pull request ComputationalRadiationPhysics#418 from BenjaminW3/topic-refactor-cpu-rand 6a56e8e Merge pull request ComputationalRadiationPhysics#423 from psychocoderHPC/fix-comparisonWarning 57fe354 Merge pull request ComputationalRadiationPhysics#424 from psychocoderHPC/topic-cuda9MinArchitecture 5e02bad Merge pull request ComputationalRadiationPhysics#421 from psychocoderHPC/fix-testBuildWithDynBoostLibs 6f19481 increase minimal CUDA archtitecture for CUDA 9 fd416e3 fix comparison warning in `Vec.hpp` 277a7ee fix test builds with dynamic boost lib f9e0baf factor out MersenneTwister CPU random number generator 0d4790a Merge pull request ComputationalRadiationPhysics#413 from ax3l/topic-lastTypedefs 51b3c35 Merge pull request ComputationalRadiationPhysics#412 from BenjaminW3/topic-clean-up e0bb8b0 Merge pull request ComputationalRadiationPhysics#396 from BenjaminW3/topic-events-CUDA c633d4f Remove typedef ec2b9a6 minimal clean ups 40d6b14 fix CPU event ec282a8 add event tests for CUDA 6c4c9c1 Merge pull request ComputationalRadiationPhysics#333 from BenjaminW3/topic-clang-4_0 839ee02 clang 4.0+ native CUDA 4b87306 Merge pull request ComputationalRadiationPhysics#402 from BenjaminW3/topic-OpenMP-4-clang 0112d8f fix OpenMP 4 backend for clang f1bce5e Merge pull request ComputationalRadiationPhysics#411 from ax3l/doc-noCUDAver 66201a5 Doc: No __CUDA_VER__ 2c2c216 Merge pull request ComputationalRadiationPhysics#384 from BenjaminW3/topic-cuda-9_0 e038a82 CUDA 9.0 30c94aa Merge pull request ComputationalRadiationPhysics#410 from BenjaminW3/topic-ubuntu_16_04 4e2ecf8 use newer ubuntu images in CI 476815d Merge pull request ComputationalRadiationPhysics#408 from BenjaminW3/topic-clean-up-build-logs ffe8d0b add UBSan blacklist items 986aec2 remove large file printing eb395e9 Merge pull request ComputationalRadiationPhysics#407 from BenjaminW3/topic-docker 107049d create a docker image per job and cache it 99db278 fix flaky appveyor builds aa91011 Merge pull request ComputationalRadiationPhysics#406 from BenjaminW3/topic-remove-uuid b11958f remove boost.uuid from UBSan blacklist 3cc093a rename all stream impl members to shorter and identical names for clearness 22e8aff replace comparison of underlying event/stream with comparison of impl shared_ptr ed3f89a remove uuid because it is unused 7dd080d Merge pull request ComputationalRadiationPhysics#404 from BenjaminW3/topic-kernel-unit-test-extension f5dd1a9 use the 64 bit toolset on appveyor to work around out of heap space issues 4b92e4b add kernel unit tests 0e7c221 Merge pull request ComputationalRadiationPhysics#397 from BenjaminW3/topic-refactor-travis_yml 19b0ec8 refactor .travis.yml 002b359 Merge pull request ComputationalRadiationPhysics#401 from BenjaminW3/topic-clang-5 3ab46c6 add support for clang 5 d4753f8 Merge pull request ComputationalRadiationPhysics#400 from BenjaminW3/topic-drop-clang-3_8-native-CUDA a30f1ee drop support for native CUDA compilation with clang-3.8 due to missing support of cuRand 2ed4755 Merge pull request ComputationalRadiationPhysics#386 from BenjaminW3/topic-boost-1_65 4d9e8e6 Merge pull request ComputationalRadiationPhysics#398 from psychocoderHPC/topic-hashedAtomicStlLock 7941d30 add github annotations f1f317e add support for boost-1.65 886b1ab use `AtomicStlLock<16>` fa31544 AtomicStlLock: use array of mutex git-subtree-dir: thirdParty/alpaka git-subtree-split: 7543802fe85bce308374324be145551fa82eeb8d

Update example .param files with src tree

6e6e672

f-schmitt added the documentation label Apr 30, 2014

f-schmitt added this to the Open Beta milestone Apr 30, 2014

f-schmitt assigned ax3l Apr 30, 2014

ax3l reviewed Apr 30, 2014
View reviewed changes

PrometheusPi reviewed Apr 30, 2014
View reviewed changes

Revert some changes as requested by review

c5a5703

ax3l reviewed Apr 30, 2014
View reviewed changes

f-schmitt added 2 commits April 30, 2014 12:49

Fix indentations

b17efb0

Revert changes to SPRWL laserConfig

c5e1540

One more ident problem and revert change in rad.

c599c21

ax3l reviewed Apr 30, 2014
View reviewed changes

ax3l mentioned this pull request May 1, 2014

Check ABSORBER_FADE_IN_STEPS #390

Closed

Revert change to precision.param

e9752cb

ax3l added a commit that referenced this pull request May 3, 2014

Merge pull request #384 from f-schmitt-zih/fix-paramFiles

c28f5fb

Update example .param files with src tree

ax3l merged commit c28f5fb into ComputationalRadiationPhysics:dev May 3, 2014

f-schmitt deleted the fix-paramFiles branch June 16, 2014 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update example .param files with src tree #384

Update example .param files with src tree #384

f-schmitt commented Apr 30, 2014

f-schmitt commented Apr 30, 2014

PrometheusPi commented Apr 30, 2014

ax3l Apr 30, 2014

f-schmitt Apr 30, 2014

PrometheusPi commented Apr 30, 2014

PrometheusPi Apr 30, 2014

ax3l Apr 30, 2014

ax3l Apr 30, 2014

psychocoderHPC Apr 30, 2014

ax3l May 1, 2014

PrometheusPi commented Apr 30, 2014

ax3l commented Apr 30, 2014

f-schmitt commented Apr 30, 2014

PrometheusPi commented Apr 30, 2014

ax3l Apr 30, 2014

ax3l commented May 3, 2014


		/** unit: Volt /meter */
		//const double AMPLITUDE_SI = _A0 * UNITCONV_A0_to_Amplitude_SI;

Update example .param files with src tree #384

Update example .param files with src tree #384

Conversation

f-schmitt commented Apr 30, 2014

f-schmitt commented Apr 30, 2014

PrometheusPi commented Apr 30, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PrometheusPi commented Apr 30, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PrometheusPi commented Apr 30, 2014

ax3l commented Apr 30, 2014

f-schmitt commented Apr 30, 2014

PrometheusPi commented Apr 30, 2014

Choose a reason for hiding this comment

ax3l commented May 3, 2014