-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openPMD plugin: do not use JSON configurations when restarting #3674 #3675
openPMD plugin: do not use JSON configurations when restarting #3674 #3675
Conversation
@franzpoeschel Thank you for providing this fix that quickly 👍 |
I am not sure if the "bug" label applies, feel free to change if necessary. |
I compiled the pull request with a previously failing setup on taurus ml and will report back if it solves the issue. |
Maybe technically not PIConGPU's fault, but the current behavior leads to crashes where one would not expect any. Calling that a bug is justified in my opinion. |
I tried running a restart on taurus ml, but now got the following error:
|
I will merge this PR, the issue from @PrometheusPi is with high probability triggered by problems. |
Yes, @psychocoderHPC is right, the error message above originated from a changed absorber default. |
Note: ADIOS2 has now read parameters, e.g. for setting the number of threads in decompression. So, we might want to add some functionality into PIConGPU to use this now again. |
It is currently impossible to specify different plugin parameters for checkpointing and restarting. ADIOS2 reading routines do apparently read the
InitialBufferSize
parameter even when opened in read-only mode. See screenshot below: Memory profile when reading 16 iterations, one time not specifying theInitialBufferSize
, one time specifying it.Since there is currently no useful configuration to use for reading routines when restarting, just don't use JSON configurations at all when reading.