fix gamma filter transition radiation #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrometheusPi
added
bug
PrometheusPi
force-pushed
the
fix_gammaFIlter_CTRplugin
branch
from
7fb3c56 to
c499c0c
Compare
finnolec
approved these changes
Nov 11, 2019
sbastrakov
approved these changes
Nov 12, 2019
|
ready for review/merge |
|
@psychocoderHPC are you planning to review it? Looks good to me. |
psychocoderHPC
approved these changes
Nov 22, 2019
|
@PrometheusPi if this bug shall show up in the changelog of the next release, do not forget to set the "affects latest release" label :) |
|
@ax3l luckily it just effects the current dev 🎉 - so no need to add this in the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the transition radiation plugin that prevented the gamma filter from working.
The
transitionRadiationMaskwas set as flag not as attribute, thus the filter was never applied and assumed to be always true.The documentation was updated alongside.