Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include int16 and uint16 types as traits for ADIOS #2929

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Include int16 and uint16 types as traits for ADIOS #2929

merged 2 commits into from
Mar 25, 2019

Conversation

BeyondEspresso
Copy link
Member

Based on the discussion #2928 this PR fixes a bug, in which picongpu fails to compile when both ADIOS and particle merging are activated. Hence int16 and uint16 are now included as traits for ADIOS.

@ax3l ax3l added the component: plugin in PIConGPU plugin label Mar 23, 2019
@ax3l ax3l self-assigned this Mar 23, 2019
@ax3l ax3l self-requested a review March 23, 2019 22:00
@ax3l ax3l added bug a bug in the project's code affects latest release a bug that affects the latest stable release labels Mar 23, 2019
@ax3l
Copy link
Member

ax3l commented Mar 23, 2019 •
edited
Loading

@BeyondEspresso thanks a lot! Can you please also add the new traits to AdiosToPIC.tpp, so we are able to read such types as well? :)

@BeyondEspresso
Copy link
Member Author

@ax3l Good idea! Done.

ax3l
ax3l approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@ax3l ax3l merged commit 9642b3f into ComputationalRadiationPhysics:dev Mar 25, 2019
@ax3l ax3l mentioned this pull request Mar 25, 2019
Closed
@psychocoderHPC psychocoderHPC deleted the topic-adios-int16 branch March 26, 2019 09:36
@psychocoderHPC psychocoderHPC added this to the 0.5.0 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
affects latest release a bug that affects the latest stable release bug a bug in the project's code component: plugin in PIConGPU plugin
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BeyondEspresso @ax3l @psychocoderHPC