Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup pmacc/types.hpp #2927

Merged

Conversation

psychocoderHPC
Copy link
Member

Cleanup the misc header pmacc/types.hpp (our eierlegende Wollmilchsau) to support later refactorings of other classes to support compiling in independent compile units.

Move all definitions from types.hpp in independant files.

This PR is not changing the implementations and is fully backward compatible. To support the backwards compatibility all definitions within a hierarchical namespace is pulled into the pmacc namespace.

Cleanup the misc header `pmacc/types.hpp` to support later refactorings of other classes to support compiling in independant compile units.

Move all definitions from types.hpp in independant files.
@psychocoderHPC psychocoderHPC added component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API labels Mar 22, 2019
@ax3l ax3l self-assigned this Mar 23, 2019
@ax3l ax3l merged commit cbe4dbc into ComputationalRadiationPhysics:dev Mar 23, 2019
@psychocoderHPC psychocoderHPC deleted the topic-pmaccTypesCleanup branch March 26, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants