Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for particle filters #2397

Conversation

psychocoderHPC
Copy link
Member

@psychocoderHPC psychocoderHPC commented Nov 20, 2017

  • PMacc: use particle filters in ResourceMonitor, ConcatListOfFrames and CountParticles
  • PIConGPU:
    • add helper class SpeciesFilter
    • Prepare all plugins which uses PMacc particle methods to be particle filter ready.

Note: ConcatListOfFrames is currently hacky. All usages of alpaka accelerators are filled with fake values. This means that is it currently not possible to use accelerator dependent functions (RNG, ...) with the filter. We need to rewrite ConcatListOfFrames as proper alpaka kernel. This is not possible currently until we fully switch to alpaka (currently we are running in a mixed mode with native CUDA).

WARNING the species names in the output files from HDF5 and ADIOS will be change after this PR. New name are <speciesName>_<filternName>. The current used default filter is all this means electrons are named e_all.

Related to #1288

Tests

  • write HDF5 and HDF5
  • restart ADIOS
  • restart HDF5

Add particle filter to for `ResourceMonitor`, `ConcatListOfFrames` and `CountParticles`.
add helper class `SpeciesFilter`
@psychocoderHPC psychocoderHPC added component: PMacc in PMacc component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API labels Nov 20, 2017
@psychocoderHPC psychocoderHPC added this to the 0.4.0 / 1.0.0: Next Stable milestone Nov 20, 2017
@psychocoderHPC psychocoderHPC requested a review from ax3l November 20, 2017 13:59
Prepare all plugins which uses PMacc particle methods to be particle filter ready.
@psychocoderHPC psychocoderHPC force-pushed the topic-preworkForSpeciesFilter branch from 1ddf555 to 5856d73 Compare November 21, 2017 09:19
@psychocoderHPC
Copy link
Member Author

ready for a review

@ax3l ax3l merged commit 300e7b0 into ComputationalRadiationPhysics:dev Nov 21, 2017
@psychocoderHPC psychocoderHPC deleted the topic-preworkForSpeciesFilter branch November 21, 2017 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plugin in PIConGPU plugin component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants