XDMF Scripts: Fix Replacements & Offset #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the particle offset naming since the introduction of openPMD and fix missing ".format()" replacements with multi-line strings.
ax3l
added
affects latest release
PrometheusPi
approved these changes
Oct 17, 2017
| node_text = "/Xdmf/Domain/Grid/{}Attribute[@Name='{}']/" + \ | ||
| "DataItem[1]".format(extra_grid, orig_name) | ||
| node_text = ("/Xdmf/Domain/Grid/{}Attribute[@Name='{}']/" | ||
| "DataItem[1]").format(extra_grid, orig_name) |
There was a problem hiding this comment.
OPTIONAL:
A plus sign + is optional here but would improve readability of the code to emphasize that here the second string is attached.
There was a problem hiding this comment.
I would not add it since it is superfluous like additional brackets.
the way it is now is the common way to do it properly.
ax3l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the particle offset naming since the introduction of openPMD and fix missing
.format()replacements with multi-line strings.The latter issue was introduces with #2145, the former with release
0.2.0.