Background Fields: Fix Restart GUARD #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrometheusPi
previously approved these changes
Jul 17, 2017
ax3l
force-pushed
the
fix-RestartBGFields
branch
2 times, most recently
from
f3d1c21 to
fd795b0
Compare
Simplify the logic of restarting fields: - do not add the already contained fields in `movingWindowCheck` again - spares us the substraction we had before - GUARDS are not part of the checkpoint data, which is cumbersome for the "outer" GUARDS of our global domain - we need to add the background field ONLY in those to generate a valid restart field
ax3l
force-pushed
the
fix-RestartBGFields
branch
from
fd795b0 to
494865e
Compare
|
I verified this fix with the field background example from #2137. I used only the field background for the E field. |
PrometheusPi
pushed a commit
to PrometheusPi/picongpu
that referenced
this pull request
Jul 17, 2017
|
@ax3l l see above for the backport to 0.3.0 - it is the last commit |
|
run time test results: |
PrometheusPi
pushed a commit
to PrometheusPi/picongpu
that referenced
this pull request
Jul 17, 2017
|
@BeyondEspresso please take note of this bugfix fo restarts with background fields if you have not seen it yet. also applies to (all) previous releases! (sorry :( ) included since we added the field background to the plugins (for you ;) ) |
|
Guys, this is awesome! 😃 Great work, all of you! 🥇 |
psychocoderHPC
approved these changes
Jul 18, 2017
ax3l
added a commit
to ax3l/picongpu
that referenced
this pull request
Jul 18, 2017
ax3l
added
the
affects latest release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Trying) to close #2137:
Restart of background fields could cause:
Simplify the logic of restarting fields:
movingWindowCheckagain