Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libSplash Version Checker #151

Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 23, 2014

  • read patch level, too
  • check for minimum version of libSplash, else ignore as if
    it would be not provided (missing plugins shall not throw
    errors)

- read patch level, too
- check for minimum version of libSplash, else ignore as if
  it would be not provided (missing plugins shall not throw
  errors)
@ghost ghost assigned f-schmitt Jan 23, 2014
@ax3l
Copy link
Member Author

ax3l commented Jan 23, 2014

Since the include path changed and the patch level was missing, users with 1.0 will get an error right now instead of a warning.
But this will work fine for later versions of libSplash, throwing something like:

-- Found libSplash: /opt/pkg/filelib/libsplash/1.0 (found version "1.0")
CMake Warning at src/picongpu/CMakeLists.txt:300 (message):
  libSplash version is smaller than the required version 1.1.0 - not using

-- Could NOT find libSplash for hdf5 output

This will later on be transformed in a find_package module, see ComputationalRadiationPhysics/libSplash#78 .

f-schmitt pushed a commit that referenced this pull request Jan 24, 2014
@f-schmitt f-schmitt merged commit fa6b96f into ComputationalRadiationPhysics:dev Jan 24, 2014
@f-schmitt f-schmitt mentioned this pull request Jan 24, 2014
@ax3l ax3l deleted the topic-CMakeSplashVersion branch January 24, 2014 09:05
ax3l pushed a commit to ax3l/picongpu that referenced this pull request Feb 14, 2019
e2533d141 Merge pull request ComputationalRadiationPhysics#153 from psychocoderHPC/topic-versionIncrease2.3.1
2723bc13d Merge pull request ComputationalRadiationPhysics#154 from ax3l/topic-cmake312rootHints
60c467ece version increase to 2.3.1
5f57e6d1f CMake: Honor _ROOT Env Hints
e0bbb5fdd Merge pull request ComputationalRadiationPhysics#151 from ax3l/merge-v230master
16cd2b9a5 Merge remote-tracking branch 'mainline/master' into merge-v230master
8dbb2dd6e Merge pull request ComputationalRadiationPhysics#150 from psychocoderHPC/fix-warpsPerSM
cab1dd5fc fix style, fix wrong used qualifier
5a71062db fix illegal memory access

git-subtree-dir: thirdParty/mallocMC
git-subtree-split: e2533d14101c9fa7af3d11b9d02277591e06d8e4
ax3l pushed a commit to ax3l/picongpu that referenced this pull request Feb 14, 2019
e2533d141 Merge pull request ComputationalRadiationPhysics#153 from psychocoderHPC/topic-versionIncrease2.3.1
2723bc13d Merge pull request ComputationalRadiationPhysics#154 from ax3l/topic-cmake312rootHints
60c467ece version increase to 2.3.1
5f57e6d1f CMake: Honor _ROOT Env Hints
e0bbb5fdd Merge pull request ComputationalRadiationPhysics#151 from ax3l/merge-v230master
16cd2b9a5 Merge remote-tracking branch 'mainline/master' into merge-v230master
8dbb2dd6e Merge pull request ComputationalRadiationPhysics#150 from psychocoderHPC/fix-warpsPerSM
cab1dd5fc fix style, fix wrong used qualifier
5a71062db fix illegal memory access

git-subtree-dir: thirdParty/mallocMC
git-subtree-split: e2533d14101c9fa7af3d11b9d02277591e06d8e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tools scripts, python libs and CMake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants