Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions: Code Documentation and Readability #142

Open
n01r opened this issue Jan 22, 2014 · 6 comments
Open

Suggestions: Code Documentation and Readability #142

n01r opened this issue Jan 22, 2014 · 6 comments
Labels
documentation regarding documentation or wiki discussions
Milestone

Comments

@n01r
Copy link
Member

n01r commented Jan 22, 2014

Code Documentation and Readability

I was asked to give feedback on what information I would wish to have as a user when I want to write a plugin for PIConGPU and thus I collected some ideas.

How is the simulation domain organised inside the code in general and down to the particles in detail?

  • Schematic pictures (about blocks, supercells, lists of frames, particles in frames and their attributes)

What basic framework do I need to have before I can implement the methods I want to use in my plugin?

  • Availability of skeletal prototypes for plugins to adapt to the 'customer's' needs

    they should be commented in detail to make the user grab the thoughts behind the code structure
    (For an orientation section 4.1 in Benjamin's thesis was quite instructive)

What particle attributes are there and how can they be accessed?

  • a picturesque "tree" of all the available namespaces,a short explanation of their substructure and where to find what

Which operators have been overloaded and what basic functions are already available to the user?

  • e.g. vector calculation methods
@ax3l
Copy link
Member

ax3l commented Jan 22, 2014

Hi n01r, thank you for your feedback!

We already started the documentation in the wiki and what you are looking for should be placed in the section Developer Documentation.

How is the simulation domain organised inside the code in general and down to the particles in detail?
Schematic pictures (about blocks, supercells, lists of frames, particles in frames and their attributes)

great, let us write a new page for that, just explaining that abstract objects.

Availability of skeletal prototypes for plugins to adapt to the 'customer's' needs.

I think based on the section above, the link in the wiki so far to Benjamin's diploma thesis works for that.
But I would like to review/add-a-new section for the wiki. (Would you like to do that? It is always quite good to read a manual from someone who just understood the stuff and still has the pitfalls in mind.)

What particle attributes are there and how can they be accessed?

Partly related to that part of the libPMacc user documentation.
Also relevant for a new section/page for the general PIConGPU user documentation.

Which operators have been overloaded and what basic functions are already available to the user?

  • e.g. vector calculation methods

@psychocoderHPC Probably a part of the libPMacc documentation for PMacc::math::? Right now most of the overloaded vector operators are performed dot wise. Everything else can be taken from PMacc::math:: (if implemented).

@PrometheusPi
Copy link
Member

Great suggestions!
I would like to add, that a detailed user description for each plugin should be added in the PIConGPU User Documentation.

@ax3l
Copy link
Member

ax3l commented Jan 22, 2014

Great idea. That is ... unfortunately ... not the case yet (only the short version in the command line manual is provided).
I also think that plugins are the part of the code that should be above-averaged documented.
@PrometheusPi Please add that point as a to-do to the PIConGPU User Documentation.

@PrometheusPi
Copy link
Member

@ax3l I agree with you, that the plugins should be documented above-average.
I will add this to the to-do-list and will create a template in the PIConGPU User Documentation

@n01r
Copy link
Member Author

n01r commented Jan 22, 2014

I will try to put my little experience with producing a running plugin into a little manual in the wiki, then.

@PrometheusPi
Copy link
Member

added an extra page for user plugin documentation
PIConGPU-User-Documentation - Plugins

@PrometheusPi PrometheusPi mentioned this issue Jan 22, 2014
19 tasks
@ax3l ax3l modified the milestones: Future, 0.2.0: Open Beta Nov 11, 2016
ax3l pushed a commit to ax3l/picongpu that referenced this issue Nov 1, 2017
3531c29c0 Merge pull request ComputationalRadiationPhysics#144 from psychocoderHPC/topic-cuda9Ballot
8d64e2050 support for CUDA9 `__ballot_sync`
782856440 Merge pull request ComputationalRadiationPhysics#142 from ax3l/fix-traitsMissingInclude
b88a134e1 Traits: Missing Boost Include

git-subtree-dir: thirdParty/mallocMC
git-subtree-split: 3531c29c0d2a88be45508a789eab624cb0dd4fc5
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this issue Feb 20, 2020
f60a0ac72c Merge pull request ComputationalRadiationPhysics#155 from ComputationalRadiationPhysics/dev
4c73dde10d Merge pull request ComputationalRadiationPhysics#152 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
fc428aa8e9 update release date for 0.2.0
1e32118c80 Merge pull request ComputationalRadiationPhysics#154 from sbastrakov/topic-addInt3Float3
84008fb6ae Add float3 and int3 with make-functions
4d5eace02a Merge pull request ComputationalRadiationPhysics#153 from sbastrakov/topic-finalizeBlackScholes2
bc35f6a822 Add Black-Scholes example
4b1ab5722f Merge pull request ComputationalRadiationPhysics#146 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
52ddba6b26 changelog and version increase to 0.2.0
aabb8d5339 Merge pull request ComputationalRadiationPhysics#145 from psychocoderHPC/fix-minimalCMakeRequirements
7795e58c0c Merge pull request ComputationalRadiationPhysics#147 from psychocoderHPC/topic-updateAuthorSection
974afe8451 Merge pull request ComputationalRadiationPhysics#150 from sbastrakov/doc-clarifyThreadUnsafety
caf4fdda1e Extend the docs with thread unsafety
91d78da7eb Merge pull request ComputationalRadiationPhysics#149 from psychocoderHPC/topic-setTravisCmakeToMinimumRequiredVersion
a3bc920dfa use CMake 3.11.4 for travis tests
9ccab281e9 update author section
6bc13a220c Merge pull request ComputationalRadiationPhysics#148 from psychocoderHPC/topic-cuplaLogo
406fb5b93a update minimal CMake requirements to 3.11.4
9c32408da3 add cupla logo
cd6b9859d4 Merge pull request ComputationalRadiationPhysics#144 from psychocoderHPC/topic-hipPinnedMemory
c9fb7dd047 pin memory allocated with `cuplaMallocHoast`
92f8c82474 Merge pull request ComputationalRadiationPhysics#143 from psychocoderHPC/topic-updateAlpakaTo0.4.0
27f0bca235 Merge commit '0f175188a374a0194145728f2083256e1eb14b13' into topic-updateAlpakaTo0.4.0
0f175188a3 Squashed 'alpaka/' changes from d5e59590f..ab0b8a460
1e4aea9747 Merge pull request ComputationalRadiationPhysics#142 from sbastrakov/fix-typeCastWarnings
8f453a4bf5 Fix warnings concerning type casting
08f80ef24b Merge pull request ComputationalRadiationPhysics#141 from sbastrakov/topic-extendAtomicComments
b3d34b28ab Extend comments of atomic functions

git-subtree-dir: thirdParty/cupla
git-subtree-split: f60a0ac72cb175d4a8a67301882f7a6b1de4c3c3
BrianMarre pushed a commit to BrianMarre/picongpu that referenced this issue Apr 27, 2020
f60a0ac72c Merge pull request ComputationalRadiationPhysics#155 from ComputationalRadiationPhysics/dev
4c73dde10d Merge pull request ComputationalRadiationPhysics#152 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
fc428aa8e9 update release date for 0.2.0
1e32118c80 Merge pull request ComputationalRadiationPhysics#154 from sbastrakov/topic-addInt3Float3
84008fb6ae Add float3 and int3 with make-functions
4d5eace02a Merge pull request ComputationalRadiationPhysics#153 from sbastrakov/topic-finalizeBlackScholes2
bc35f6a822 Add Black-Scholes example
4b1ab5722f Merge pull request ComputationalRadiationPhysics#146 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
52ddba6b26 changelog and version increase to 0.2.0
aabb8d5339 Merge pull request ComputationalRadiationPhysics#145 from psychocoderHPC/fix-minimalCMakeRequirements
7795e58c0c Merge pull request ComputationalRadiationPhysics#147 from psychocoderHPC/topic-updateAuthorSection
974afe8451 Merge pull request ComputationalRadiationPhysics#150 from sbastrakov/doc-clarifyThreadUnsafety
caf4fdda1e Extend the docs with thread unsafety
91d78da7eb Merge pull request ComputationalRadiationPhysics#149 from psychocoderHPC/topic-setTravisCmakeToMinimumRequiredVersion
a3bc920dfa use CMake 3.11.4 for travis tests
9ccab281e9 update author section
6bc13a220c Merge pull request ComputationalRadiationPhysics#148 from psychocoderHPC/topic-cuplaLogo
406fb5b93a update minimal CMake requirements to 3.11.4
9c32408da3 add cupla logo
cd6b9859d4 Merge pull request ComputationalRadiationPhysics#144 from psychocoderHPC/topic-hipPinnedMemory
c9fb7dd047 pin memory allocated with `cuplaMallocHoast`
92f8c82474 Merge pull request ComputationalRadiationPhysics#143 from psychocoderHPC/topic-updateAlpakaTo0.4.0
27f0bca235 Merge commit '0f175188a374a0194145728f2083256e1eb14b13' into topic-updateAlpakaTo0.4.0
0f175188a3 Squashed 'alpaka/' changes from d5e59590f..ab0b8a460
1e4aea9747 Merge pull request ComputationalRadiationPhysics#142 from sbastrakov/fix-typeCastWarnings
8f453a4bf5 Fix warnings concerning type casting
08f80ef24b Merge pull request ComputationalRadiationPhysics#141 from sbastrakov/topic-extendAtomicComments
b3d34b28ab Extend comments of atomic functions

git-subtree-dir: thirdParty/cupla
git-subtree-split: f60a0ac72cb175d4a8a67301882f7a6b1de4c3c3
BrianMarre pushed a commit to BrianMarre/picongpu that referenced this issue Apr 29, 2020
f60a0ac72c Merge pull request ComputationalRadiationPhysics#155 from ComputationalRadiationPhysics/dev
4c73dde10d Merge pull request ComputationalRadiationPhysics#152 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
fc428aa8e9 update release date for 0.2.0
1e32118c80 Merge pull request ComputationalRadiationPhysics#154 from sbastrakov/topic-addInt3Float3
84008fb6ae Add float3 and int3 with make-functions
4d5eace02a Merge pull request ComputationalRadiationPhysics#153 from sbastrakov/topic-finalizeBlackScholes2
bc35f6a822 Add Black-Scholes example
4b1ab5722f Merge pull request ComputationalRadiationPhysics#146 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
52ddba6b26 changelog and version increase to 0.2.0
aabb8d5339 Merge pull request ComputationalRadiationPhysics#145 from psychocoderHPC/fix-minimalCMakeRequirements
7795e58c0c Merge pull request ComputationalRadiationPhysics#147 from psychocoderHPC/topic-updateAuthorSection
974afe8451 Merge pull request ComputationalRadiationPhysics#150 from sbastrakov/doc-clarifyThreadUnsafety
caf4fdda1e Extend the docs with thread unsafety
91d78da7eb Merge pull request ComputationalRadiationPhysics#149 from psychocoderHPC/topic-setTravisCmakeToMinimumRequiredVersion
a3bc920dfa use CMake 3.11.4 for travis tests
9ccab281e9 update author section
6bc13a220c Merge pull request ComputationalRadiationPhysics#148 from psychocoderHPC/topic-cuplaLogo
406fb5b93a update minimal CMake requirements to 3.11.4
9c32408da3 add cupla logo
cd6b9859d4 Merge pull request ComputationalRadiationPhysics#144 from psychocoderHPC/topic-hipPinnedMemory
c9fb7dd047 pin memory allocated with `cuplaMallocHoast`
92f8c82474 Merge pull request ComputationalRadiationPhysics#143 from psychocoderHPC/topic-updateAlpakaTo0.4.0
27f0bca235 Merge commit '0f175188a374a0194145728f2083256e1eb14b13' into topic-updateAlpakaTo0.4.0
0f175188a3 Squashed 'alpaka/' changes from d5e59590f..ab0b8a460
1e4aea9747 Merge pull request ComputationalRadiationPhysics#142 from sbastrakov/fix-typeCastWarnings
8f453a4bf5 Fix warnings concerning type casting
08f80ef24b Merge pull request ComputationalRadiationPhysics#141 from sbastrakov/topic-extendAtomicComments
b3d34b28ab Extend comments of atomic functions

git-subtree-dir: thirdParty/cupla
git-subtree-split: f60a0ac72cb175d4a8a67301882f7a6b1de4c3c3
sbastrakov pushed a commit to sbastrakov/picongpu that referenced this issue Feb 5, 2021
f60a0ac72c Merge pull request ComputationalRadiationPhysics#155 from ComputationalRadiationPhysics/dev
4c73dde10d Merge pull request ComputationalRadiationPhysics#152 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
fc428aa8e9 update release date for 0.2.0
1e32118c80 Merge pull request ComputationalRadiationPhysics#154 from sbastrakov/topic-addInt3Float3
84008fb6ae Add float3 and int3 with make-functions
4d5eace02a Merge pull request ComputationalRadiationPhysics#153 from sbastrakov/topic-finalizeBlackScholes2
bc35f6a822 Add Black-Scholes example
4b1ab5722f Merge pull request ComputationalRadiationPhysics#146 from psychocoderHPC/topic-changeLogVersionIncreaseTo0.2.0
52ddba6b26 changelog and version increase to 0.2.0
aabb8d5339 Merge pull request ComputationalRadiationPhysics#145 from psychocoderHPC/fix-minimalCMakeRequirements
7795e58c0c Merge pull request ComputationalRadiationPhysics#147 from psychocoderHPC/topic-updateAuthorSection
974afe8451 Merge pull request ComputationalRadiationPhysics#150 from sbastrakov/doc-clarifyThreadUnsafety
caf4fdda1e Extend the docs with thread unsafety
91d78da7eb Merge pull request ComputationalRadiationPhysics#149 from psychocoderHPC/topic-setTravisCmakeToMinimumRequiredVersion
a3bc920dfa use CMake 3.11.4 for travis tests
9ccab281e9 update author section
6bc13a220c Merge pull request ComputationalRadiationPhysics#148 from psychocoderHPC/topic-cuplaLogo
406fb5b93a update minimal CMake requirements to 3.11.4
9c32408da3 add cupla logo
cd6b9859d4 Merge pull request ComputationalRadiationPhysics#144 from psychocoderHPC/topic-hipPinnedMemory
c9fb7dd047 pin memory allocated with `cuplaMallocHoast`
92f8c82474 Merge pull request ComputationalRadiationPhysics#143 from psychocoderHPC/topic-updateAlpakaTo0.4.0
27f0bca235 Merge commit '0f175188a374a0194145728f2083256e1eb14b13' into topic-updateAlpakaTo0.4.0
0f175188a3 Squashed 'alpaka/' changes from d5e59590f..ab0b8a460
1e4aea9747 Merge pull request ComputationalRadiationPhysics#142 from sbastrakov/fix-typeCastWarnings
8f453a4bf5 Fix warnings concerning type casting
08f80ef24b Merge pull request ComputationalRadiationPhysics#141 from sbastrakov/topic-extendAtomicComments
b3d34b28ab Extend comments of atomic functions

git-subtree-dir: thirdParty/cupla
git-subtree-split: f60a0ac72cb175d4a8a67301882f7a6b1de4c3c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation regarding documentation or wiki discussions
Projects
None yet
Development

No branches or pull requests

3 participants