-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplification of the code by using glm and reducing templates #130
Simplification of the code by using glm and reducing templates #130
Conversation
example/example.cpp
Outdated
@@ -80,7 +80,7 @@ class TestSource1 | |||
isaac_float3 value = ptr[nIndex.x + nIndex.y * VOLUME_X | |||
+ nIndex.z * VOLUME_X * VOLUME_Y]; | |||
isaac_float_dim< 3 > result; | |||
result.value = value; | |||
result = value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO result
is not required anymore and you can return value
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FelixTUD PLease check this comment!
Is it possible to use the upstream version of |
Please add |
Yes for CUDA a recent glm upstream version works without adjustments, only the future hip support needs some changes |
db4cf8d
to
739bbf7
Compare
@psychocoderHPC the requested changes are integrated |
example/example.cpp
Outdated
result.value | ||
.x = value; | ||
return result; | ||
return value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I am not sure if you can return value
only. Value is a scalar. How is the implementation if you cast isaac_float
to isaac_float_dim <3>
? Is the scalar only assigned to .x
or to all 3
members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fixed now, as feature_dim
is set to 1
the type is isaac_float_dim <1>
and there is no implicit conversion from isaac_float
to isaac_float_dim <1>
739bbf7
to
97bc6f6
Compare
BREAKING CHANGES TO THE ISAAC INTERFACE