fix: Use apps filter in advanced use case search

[tushar-composio]

🔍 Review Summary

Release Note

Purpose:

• Optimizes search functionality by refining searches based on specific applications.

Changes:

• Enhancement: Improved the find_actions_by_use_case method in toolset.py with an apps filter for more precise search results.

Impact:

• Increases specificity and relevance of search results, enhancing user experience and task efficiency.

Original Description

apps was not being used in advanced use case search, if provided

---

[!IMPORTANT]
Fixes find_actions_by_use_case() in toolset.py to use apps filter in advanced search.

• Behavior:
  • Fixes find_actions_by_use_case() in toolset.py to use apps filter when advanced is true.
  • Converts apps to app_keys and passes them to search_for_a_task().
• Misc:
  • No changes to non-advanced search behavior.

^{This description was created by for 168da14. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
composio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 2, 2025 3:20pm

[entelligence-ai-pr-reviews]

Walkthrough

Final Walkthrough

The pull request introduces a refinement to the find_actions_by_use_case method within the toolset.py file. By incorporating an application filter, the update enhances the search functionality, allowing for more precise and relevant retrieval of actions based on specified applications during advanced use case searches. This change optimizes the specificity of search results, improving overall functionality.

Changes

File(s)	Summary
python/composio/tools/toolset.py	Enhanced find_actions_by_use_case method by adding an apps filter to refine search precision for advanced use case queries.

🔗 Related PRs

• fix: bring eslint + TS issues to zero #1013: The pull request aims to enhance code quality and type safety by enforcing stricter ESLint rules, refactoring code, and improving error handling, ultimately making the codebase more maintainable and robust.
• feat: update types with BE and release rc for v0.5 #1082: The content describes a pull request for refactoring backend types and updating API methods, including renaming functions, adding error types, and aligning service methods with new specifications.
• feat: Support requesting connected_account in custom action #1090: The update adds support for a connected_account parameter in custom actions within Composio, allowing retrieval of Gmail access tokens.
• feat: decrease bundle size, eslint and ts issues to zero  #1032: The update optimizes the Composio JS SDK by automating version updates, reducing JavaScript bundle size, and enhancing documentation and linting processes.

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @bot + *your message*

Example: @bot Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @bot + *feedback*

Example: @bot Do not comment on `save_auth` function !

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 168da14 in 1 minute and 16 seconds

More details

• Looked at 17 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. python/composio/tools/toolset.py:1177

• Draft comment:
  Consider handling the case where apps is None or not provided to avoid potential errors.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  Since apps is a required parameter in the function signature (*apps: AppType), Python will raise a TypeError if no arguments are provided. The parameter is not Optional, so it's not meant to handle None values. The function signature enforces this contract. Additionally, if None was passed, it would fail earlier during tuple unpacking.
  I could be wrong about how Python handles *args parameters - maybe it's possible to call this with no arguments? Also, maybe the function should support being called with no apps as a valid use case?
  No, I'm correct - *args parameters in Python create an empty tuple if no arguments are provided, but using the args in a list comprehension with no null check is fine because an empty tuple will just result in an empty list. The function clearly expects at least one app based on its docstring and usage.
  The comment should be deleted because handling None/missing apps is not necessary - the function signature already enforces that apps must be provided, and an empty tuple of apps would work fine with the list comprehension.

Workflow ID: wflow_nosUyRMvKkXLXWbo

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.