fix: no auth flag delegation

[angrybayblade]

🔍 Review Summary

Purpose

• Enhance tool setup flexibility by allowing configuration without authentication.

Changes

• Enhancement: Added a no_auth flag to the tool setup process, modifying setup_children in abs.py and applying it in local.py.
• Test: Developed tests to ensure the no_auth flag functions correctly.

Impact

• Simplifies tool configuration by removing authentication requirements, improving user experience.

Original Description

[!IMPORTANT]
Add no_auth flag to setup_children() in ToolBuilder and update LocalToolMeta to use it, with corresponding test updates.

• Behavior:
  • Add no_auth parameter to setup_children() in abs.py to set action.no_auth.
  • Update LocalToolMeta in local.py to call setup_children() with no_auth=True.
• Tests:
  • Update test_setup_children() in test_abs.py to assert SomeAction.no_auth is True.

^{This description was created by for 88400cc. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
composio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 10:17am

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 88400cc in 10 seconds

More details

• Looked at 52 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. python/tests/test_tools/test_base/test_abs.py:154

• Draft comment:
  The test correctly verifies the no_auth attribute for SomeAction. This ensures the new functionality is tested.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The setup_children method in ToolBuilder now includes a no_auth parameter, which is correctly set in the test test_setup_children. This ensures that the no_auth attribute is properly tested for actions. The test is comprehensive and covers the new functionality added in the PR.

Workflow ID: wflow_99rWWMZKtekG2jgE

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[entelligence-ai-pr-reviews]

Walkthrough

This update introduces a no_auth flag to the tool setup process, allowing tools to be configured without authentication. Key changes include:

• abs.py: Modified setup_children to accept no_auth.
• local.py: Applied no_auth=True in ToolBuilder.setup_children.
• Test Update: Verified no_auth flag functionality in test_abs.py.

These changes ensure tools can be set up without authentication, enhancing flexibility in tool configuration.

Changes

File(s)	Summary
python/composio/tools/base/abs.py	Modified setup_children method to include a no_auth parameter, allowing actions to be configured without authentication.
python/composio/tools/base/local.py	Updated ToolBuilder.setup_children call to pass no_auth=True, enabling tools to be set up without authentication.
python/tests/test_tools/test_base/test_abs.py	Added a test assertion to verify that the no_auth flag is correctly set to True for actions.

🔗 Related PRs

• feat: Support requesting connected_account in custom action #1090: The update adds support for the connected_account parameter in custom actions, enhancing the ability to retrieve access tokens, specifically for Gmail accounts, by modifying relevant functions in runtime.py.
• ci: run every 12 hours, and tag me on failure #1041: The pull request introduces automated testing via scheduled GitHub Actions and enhances Slack notifications for test failures, improving CI/CD pipeline reliability and communication.
• fix: bring eslint + TS issues to zero #1013: The pull request aims to enhance code quality and type safety by enforcing stricter TypeScript rules, refactoring code, and improving error handling for better maintainability and readability.
• fix: add custom github auth using metadata #1109: The update introduces custom GitHub authentication by requiring a github_access_token in git_clone_cmd, with error handling for missing tokens.

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @bot + *your message*

Example: @bot Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @bot + *feedback*

Example: @bot Do not comment on `save_auth` function !

[entelligence-ai-pr-reviews]

🤖 Bug Fix:

Update Method Calls for New Parameter
Ensure all calls to setup_children handle the new no_auth parameter to prevent logical errors.

---

[entelligence-ai-pr-reviews]

🤖 Bug Fix:

Security Risk: no_auth Flag Usage
Ensure no_auth is used securely by adding context checks and documenting its use.

🔧 Suggested Code Diff:

        ToolBuilder.setup_children(
            obj=cls,  # type: ignore
+           no_auth=secure_context_check(),
        )

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	)
	ToolBuilder.setup_children(
	obj=cls, # type: ignore
	no_auth=True,
	)
	if autoload:
	ToolBuilder.setup_children(
	obj=cls, # type: ignore
	no_auth=secure_context_check(),
	)
	if autoload:
	# Additional logic for autoload if necessary
	pass

---