Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine minor improvements #239

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Refine minor improvements #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3c2f2f3
feat: remove TODO comment
jaybxyz Sep 22, 2023
87f7a65
fix: fix invalid stateless check in MsgAddAccountToFundModuleSet
jaybxyz Sep 22, 2023
d4489c0
fix: remove duplicate validation
jaybxyz Sep 22, 2023
c100d28
fix: typographic error
jaybxyz Sep 22, 2023
203e8be
chore: use types.ModuleName and rename cli.go to query.go
jaybxyz Sep 22, 2023
5076078
ci: add an explicit permissions for interchaintest workflow action
jaybxyz Sep 25, 2023
d67551b
ci: replace to actor to test
jaybxyz Sep 25, 2023
f5c3d22
revert: revert tested codes
jaybxyz Sep 25, 2023
54d6a4e
Merge branch 'master' into jaybxyz/minor-fixes
jaybxyz Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom/bank/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func NewBaseKeeper(
authority string,
) Keeper {
keeper := Keeper{
BaseKeeper: bankkeeper.NewBaseKeeper(cdc, storeKey, ak, blockedAddrs, authority), // TODO: how to set authority?
BaseKeeper: bankkeeper.NewBaseKeeper(cdc, storeKey, ak, blockedAddrs, authority),
ak: alliancekeeper.Keeper{},
sk: stakingkeeper.Keeper{},
tfmk: tfmk,
Expand Down
4 changes: 0 additions & 4 deletions x/mint/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ func (ms msgServer) FundModuleAccount(goCtx context.Context, req *types.MsgFundM

func (ms msgServer) AddAccountToFundModuleSet(goCtx context.Context, req *types.MsgAddAccountToFundModuleSet) (*types.MsgAddAccountToFundModuleSetResponse, error) {
ctx := sdk.UnwrapSDKContext(goCtx)
err := req.ValidateBasic()
if err != nil {
return nil, errorsmod.Wrapf(types.ErrValidationMsg, "invalid req msg %v - err %v", req, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! we don't duplicate SDK process!

}

if ms.authority != req.Authority {
return nil, errorsmod.Wrapf(govtypes.ErrInvalidSigner, "invalid authority; expected %s, got %s", ms.authority, req.Authority)
Expand Down
6 changes: 3 additions & 3 deletions x/mint/types/msg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ func (m MsgAddAccountToFundModuleSet) GetSignBytes() []byte {

// ValidateBasic does a sanity check on the provided data.
func (m MsgAddAccountToFundModuleSet) ValidateBasic() error {
_, err := sdk.AccAddressFromBech32(m.AllowedAddress)
_, err := sdk.AccAddressFromBech32(m.Authority)
if err != nil {
return errorsmod.Wrap(err, "from address must be valid address")
return errorsmod.Wrap(err, "authority must be valid address")
}

_, err = sdk.AccAddressFromBech32(m.AllowedAddress)
if err != nil {
return errorsmod.Wrap(err, "from address must be valid address")
return errorsmod.Wrap(err, "allowed address must be valid address")
}

return nil
Expand Down
2 changes: 1 addition & 1 deletion x/ratelimit/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
// GetTxCmd returns the tx commands for router
func GetTxCmd() *cobra.Command {
txCmd := &cobra.Command{
Use: "transfermiddleware",
Use: types.ModuleName,
DisableFlagParsing: true,
SuggestionsMinimumDistance: 2,
Short: fmt.Sprintf("Tx commands for the %s module", types.ModuleName),
Expand Down
2 changes: 1 addition & 1 deletion x/transfermiddleware/client/cli/cli.go → x/transfermiddleware/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
// GetQueryCmd returns the query commands for router
func GetQueryCmd() *cobra.Command {
queryCmd := &cobra.Command{
Use: "transfermiddleware",
Use: types.ModuleName,
DisableFlagParsing: true,
SuggestionsMinimumDistance: 2,
}
Expand Down
2 changes: 1 addition & 1 deletion x/transfermiddleware/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
// GetTxCmd returns the tx commands for router
func GetTxCmd() *cobra.Command {
txCmd := &cobra.Command{
Use: "transfermiddleware",
Use: types.ModuleName,
DisableFlagParsing: true,
SuggestionsMinimumDistance: 2,
Short: "Registry and remove IBC dotsama chain information",
Expand Down