Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRACPriorInputEditor not picking up the right taxon sets #50

Open
rbouckaert opened this issue Apr 18, 2023 · 1 comment
Open

MRACPriorInputEditor not picking up the right taxon sets #50

rbouckaert opened this issue Apr 18, 2023 · 1 comment

Comments

@rbouckaert
Copy link
Member

When specifying taxonsets via the snapper template, the taxa in the MRCAPriorInputEditor

  1. are displaying too much information in the list box, since they include all sub-taxa,
  2. are not updated when they are edited in the TaxonSetInputEditor leading to incorrect XML
    See using a MRCA + snapper made mismatches with Taxon ~ TaxonSet labels beast2#1106 for an example.
rbouckaert added a commit to rbouckaert/snapper that referenced this issue May 17, 2023
rbouckaert added a commit to BEAST2-Dev/SNAPP that referenced this issue May 17, 2023
rbouckaert added a commit that referenced this issue May 17, 2023
@rbouckaert
Copy link
Member Author

When renaming a taxon, then do a "fill down" in the taxon editor it works fine now. However, adding an MRCAPrior using the newly named taxon leads to creation of invalid XML: a new Taxon is created instead of a reference to the existing taxon set, and the ID has a number added to it (maybe related to CompEvol/beast2#237).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant