Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom name in ObservablePropertyAttribute #917

Closed
wants to merge 1 commit into from
Closed

Support for custom name in ObservablePropertyAttribute #917

wants to merge 1 commit into from

Conversation

Trigve
Copy link

@Trigve Trigve commented Aug 21, 2024

**Closes #795 **

Add overloaded constructor for ObservablePropertyAttribute, which takes the name of the newly generated property.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Code follows all style conventions

Other information

@Sergio0694
Copy link
Member

Closing this. Please do not open PRs for features that have not been approved yet 🙂

@Sergio0694 Sergio0694 closed this Aug 21, 2024
@QJS-RH
Copy link

QJS-RH commented Aug 21, 2024 via email

@Trigve
Copy link
Author

Trigve commented Aug 22, 2024

@Sergio0694 Apologize, didn't know that it was duplicate and somehow missed the "do not open PRs for features that have not been approved yet" in the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Specify the generated ObservableProperty name
3 participants