Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-target Roslyn dependency in MVVM Toolkit generators #428

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Multi-target Roslyn dependency in MVVM Toolkit generators #428

merged 4 commits into from
Sep 9, 2022

Conversation

Sergio0694
Copy link
Member

Closes #423

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Code follows all style conventions

@Sergio0694 Sergio0694 added build 🔥 Some changes or issues related to build infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 8, 2022
@Sergio0694
Copy link
Member Author

NuGet content with these changes looks correct:

Hey @sharwell, could you help take a look when you have some time? I could use your MSBuild wisdom here 🙂
I think the changes for the MVVM Toolkit itself are fine, but I'm not sure how to properly setup the tests.
Any suggestions would be greatly appreciated! 😄

@Sergio0694 Sergio0694 force-pushed the dev/roslyn-multi-targeting branch from 88b9e8c to f577ec0 Compare September 8, 2022 17:36
@Sergio0694 Sergio0694 marked this pull request as ready for review September 8, 2022 17:54
@Sergio0694 Sergio0694 merged commit 5be269e into main Sep 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/roslyn-multi-targeting branch September 9, 2022 10:49
@Nirmal4G Nirmal4G mentioned this pull request Sep 15, 2022
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build 🔥 Some changes or issues related to build infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Roslyn multi-targeting for MVVM Toolkit generator
1 participant
@Sergio0694