Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scoped delegate capture in NetworkConnectionStateTrigger #4770

Conversation

Arlodotexe
Copy link
Member

Related to #4059

PR Type

What kind of change does this PR introduce?

The OnEventAction used in NetworkConnectionStateTrigger was capturing this to attach the event. This PR makes the delegate static so it doesn't capture this.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

n/a

@Arlodotexe Arlodotexe added this to the 7.1.3 milestone Sep 20, 2022
@ghost
Copy link

ghost commented Sep 20, 2022

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi September 20, 2022 14:56
@LalithaNadimpalli LalithaNadimpalli self-assigned this Sep 21, 2022
@Arlodotexe Arlodotexe added the for-review 📖 To evaluate and validate the Issues or PR label Sep 22, 2022
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Oct 27, 2022

Resolved in 60d61ad, #4787

@Arlodotexe Arlodotexe closed this Oct 27, 2022
@Arlodotexe Arlodotexe deleted the fix/NetworkConnectionStateTrigger/weakevent-oneventaction-capture branch October 27, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for-review 📖 To evaluate and validate the Issues or PR hotfix 🌶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants