Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListDetailsView.ListPaneWidth Null check fix #4738

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

LalithaNadimpalli
Copy link
Contributor

List Details View NRE check

Fixes #4357

PR Type

What kind of change does this PR introduce?

< Bugfix >

< Sample app changes >

What is the current behavior?

<_TwoPaneView passed without checking for null>

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Aug 26, 2022

Thanks LalithaNadimpalli for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi August 26, 2022 16:43
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3. labels Aug 26, 2022
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repro'd the issue, swapped the nuget package for this branch locally, and the issue was fixed.

Looks good!

@michael-hawker michael-hawker merged commit db12288 into main Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the ListDetailsView.ListPaneWidth-NRE-fix branch September 2, 2022 18:24
@pszyjaciel
Copy link

ListPaneWidth crashes with NullReferenceException. Issue still exists in WinUI3 Microsoft.WindowsAppSDK 1.5.240311000, Microsoft.UI.Xaml 2.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListDetailsView not working with WinUI3/WindowsAppSDK 1.0.0-preview3
4 participants