Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color picker button binding issue #4729

Merged

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Aug 18, 2022

Fixes

Fixes #4721

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The current SelectedValue binding throws a Binding Failure error because it tries to return a null Color property (due to BindingMode=TwoWay) that has a value type

What is the new behavior?

Added a helper converter that will ignore null values in ConvertBack, replacing them with DependencyProperty.UnsetValue

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 18, 2022

Thanks HavenDV for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi August 18, 2022 05:58
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3. labels Aug 18, 2022
@HavenDV HavenDV merged commit 4f394ce into CommunityToolkit:main Aug 18, 2022
@HavenDV HavenDV force-pushed the fix-color-picker-button-binding-issue branch from cd497a9 to b39d70f Compare August 18, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorPickerButton Binding errors
1 participant