-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ImageCropper AspectRatio not updating on image load #4720
Merged
michael-hawker
merged 16 commits into
CommunityToolkit:main
from
Arlodotexe:fix/imagecropper-aspect-ratio-not-updating-on-image-load
Sep 29, 2022
Merged
Fixed ImageCropper AspectRatio not updating on image load #4720
michael-hawker
merged 16 commits into
CommunityToolkit:main
from
Arlodotexe:fix/imagecropper-aspect-ratio-not-updating-on-image-load
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from azchohfi
August 11, 2022 21:10
ghost
added
bug 🐛
An unexpected issue that highlights incorrect behavior
controls 🎛️
labels
Aug 11, 2022
13 tasks
HHChaos
reviewed
Aug 16, 2022
Microsoft.Toolkit.Uwp.UI.Controls.Media/ImageCropper/ImageCropper.Events.cs
Outdated
Show resolved
Hide resolved
…LayoutWithViewport
Arlodotexe
force-pushed
the
fix/imagecropper-aspect-ratio-not-updating-on-image-load
branch
from
September 15, 2022 01:09
f12beed
to
6eee40a
Compare
HHChaos
reviewed
Sep 26, 2022
Microsoft.Toolkit.Uwp.UI.Controls.Media/ImageCropper/ImageCropper.Logic.cs
Outdated
Show resolved
Hide resolved
HHChaos
reviewed
Sep 26, 2022
Microsoft.Toolkit.Uwp.UI.Controls.Media/ImageCropper/ImageCropper.Properties.cs
Outdated
Show resolved
Hide resolved
HHChaos
reviewed
Sep 26, 2022
Microsoft.Toolkit.Uwp.UI.Controls.Media/ImageCropper/ImageCropper.Logic.cs
Outdated
Show resolved
Hide resolved
…per.Logic.cs Co-authored-by: hhchaos <[email protected]>
…d' of https://github.com/Arlodotexe/WindowsCommunityToolkit into fix/imagecropper-aspect-ratio-not-updating-on-image-load
HHChaos
approved these changes
Sep 28, 2022
LalithaNadimpalli
approved these changes
Sep 28, 2022
nmetulev
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
An unexpected issue that highlights incorrect behavior
controls 🎛️
for-review 📖
To evaluate and validate the Issues or PR
hotfix 🌶
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4483 #4478
Closes #4482
Fixed an issue where Aspect Ratio of the image cropper wouldn't update after the image is loaded.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Image cropper doesn't update the aspect ratio when the image is loaded.
What is the new behavior?
Aspect ratio updates correctly when image is loaded.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information