Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ImageCropper AspectRatio not updating on image load #4720

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Aug 11, 2022

Fixes #4483 #4478

Closes #4482

Fixed an issue where Aspect Ratio of the image cropper wouldn't update after the image is loaded.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Image cropper doesn't update the aspect ratio when the image is loaded.

What is the new behavior?

Aspect ratio updates correctly when image is loaded.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 11, 2022

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi August 11, 2022 21:10
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ labels Aug 11, 2022
@Arlodotexe Arlodotexe force-pushed the fix/imagecropper-aspect-ratio-not-updating-on-image-load branch from f12beed to 6eee40a Compare September 15, 2022 01:09
@Arlodotexe Arlodotexe requested a review from HHChaos September 15, 2022 01:26
@Arlodotexe Arlodotexe added the for-review 📖 To evaluate and validate the Issues or PR label Sep 22, 2022
@michael-hawker michael-hawker added this to the 7.1.3 milestone Sep 29, 2022
@michael-hawker michael-hawker merged commit 0249f73 into CommunityToolkit:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ for-review 📖 To evaluate and validate the Issues or PR hotfix 🌶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get perfect square with ImageCropper
5 participants