Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view bad insert index #4524

Closed
wants to merge 1 commit into from
Closed

Fix view bad insert index #4524

wants to merge 1 commit into from

Conversation

texaclou
Copy link

Fixes #4465

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

When ACV (AdvancedCollectionView) use a filter
When ACV don't use SortDescription
When a new item is inserted at the end of the source
Then new item is inserted in view before the last item.

What is the new behavior?

Now the new item is inserted in view after the last item, at the end.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 26, 2022

Thanks texaclou for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi March 26, 2022 07:29
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 26, 2022
@michael-hawker
Copy link
Member

michael-hawker commented Mar 28, 2022

Related/Conflicting with #4349 #4347.

We need to finish validating #4347 and add other tests here before we add a solution.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdvancedCollectionView insert at bad index
2 participants