Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextIconExtension to use Segoe Fluent Icons by default #4510

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

huynhsontung
Copy link
Contributor

Fixes #4509

Icon extensions should support the new Fluent icons introduced in Windows 11.

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

All icon extensions use "Segoe MDL2 Assets" font by default.

What is the new behavior?

FontIcon and SymbolIcon extensions will now use "Segoe Fluent Icons" by default and fallback to "Segoe MDL2 Assets" if necessary.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 14, 2022

Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi March 14, 2022 03:33
@ghost ghost added the feature request 📬 A request for new changes to improve functionality label Mar 14, 2022
@huynhsontung huynhsontung changed the title TextIconExtension uses Segoe Fluent Icons by default TextIconExtension to use Segoe Fluent Icons by default Mar 14, 2022
@michael-hawker
Copy link
Member

Thanks @huynhsontung for the PR! FYI @Sergio0694

@michael-hawker michael-hawker merged commit 3bf88b8 into CommunityToolkit:main Mar 28, 2022
@huynhsontung huynhsontung deleted the fluent-icons branch March 29, 2022 02:53
@michael-hawker michael-hawker added this to the 7.1.3 milestone Jul 14, 2022
goalend

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 📬 A request for new changes to improve functionality hotfix 🌶 introduce breaking changes 💥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] IconExtensions should use Segoe Fluent Icons font
4 participants