Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Notifications test project to .NET Core 3.1 #4501

Merged

Conversation

Sergio0694
Copy link
Member

Fixes #4500

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

CI fails due to no .NET Core 2.1 SDK installed.

What is the new behavior?

CI builds and runs correctly.

@ghost
Copy link

ghost commented Mar 5, 2022

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi March 5, 2022 02:23
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior priority 🚩 labels Mar 5, 2022
@michael-hawker michael-hawker added this to the 8.0 milestone Mar 7, 2022
@michael-hawker
Copy link
Member

That was simple! Thanks so much @Sergio0694! 🦙❤

@michael-hawker michael-hawker merged commit 4f394ce into CommunityToolkit:main Mar 7, 2022
@Sergio0694 Sergio0694 deleted the fix/remove-net-core-2.1 branch March 7, 2022 18:22
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 CI/pipeline 🔬 hotfix 🌶 priority 🚩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] Build Failure .NET Core 2.1.0 missing
2 participants