Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DependencyProperty assign exception. #4466

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

Morgomirius
Copy link
Contributor

@Morgomirius Morgomirius commented Jan 21, 2022

Fixed bug that was making AnimationProperty or TargetObjectProperty unavailable to assign via xaml, because DependencyProperty ownerType was wrong.

Fixes

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • Currently, it throws an Exception.

What is the new behavior?

  • Exception is no longer thrown.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Fixed bug that was making AnimationProperty or TargetObjectProperty unavailable to assign via xaml, because DependencyProperty ownerType was wrong.
@ghost
Copy link

ghost commented Jan 21, 2022

Thanks Morgomirius for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi January 21, 2022 22:18
@michael-hawker michael-hawker added this to the 8.0 milestone Jan 25, 2022
@michael-hawker michael-hawker added animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior labels Jan 25, 2022
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this @Morgomirius! 🎉

(Not sure how we missed it, definitely a copy-paste bug. 🤦‍♂️)

@michael-hawker michael-hawker merged commit 6d300f0 into CommunityToolkit:main Jan 25, 2022
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants