Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for toast scenario #4464

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

andrewleader
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Adding unit tests

What is the current behavior?

There aren't any unit tests for toast scenario XML properties (like alarm, reminder, etc)

What is the new behavior?

Added a unit test to test all toast scenarios. No functional change, just adding a test.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • x] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jan 21, 2022

Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@andrewleader
Copy link
Contributor Author

@azchohfi appreciate your review on this when you get a chance, the notifications team will be adding a new toast scenario in the future and I noticed we didn't have any tests for the toast scenario property, hence I wanted to get some tests added before they do the work to add a new scenario :)

@andrewleader
Copy link
Contributor Author

Ah I noticed this never got merged, @azchohfi can you review? Thx! Super straightforward, just adding some unit tests :)

@azchohfi azchohfi merged commit 7eed078 into main May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the aleader/add-toast-scenario-tests branch May 25, 2022 21:02
@michael-hawker
Copy link
Member

@Sergio0694 we'll want to make sure your other PR is updated to grab this test for regression checking.

@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants