-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfoBar StackedNotificationsBehavior #4399
Conversation
Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation. Not convinced we need a separate NotificationWithOverrides class, though.
Microsoft.Toolkit.Uwp.UI.Behaviors/InfoBar/NotificationWithOverrides.cs
Outdated
Show resolved
Hide resolved
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Microsoft.Toolkit.Uwp.UI.Behaviors/InfoBar/StackedNotificationsBehavior.cs
Show resolved
Hide resolved
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Build failing due to style cop rules:
|
@vgromfeld we've moved this over to the new Windows Community Toolkit Labs. 🎉 CommunityToolkit/Labs-Windows#211 - tracking experiment here: CommunityToolkit/Labs-Windows#210 I've copied over most of your PR (waiting for some sample improvements to make it easier to implement more samples over the next couple of weeks). Also, a bit tripped up on a build issue with long-path I think. Anyway, going to close out this PR over here for now, as we'll continue that work forward and then bring the component back to the main repo after we re-organize for 8.0. Labs will allow us to continue development easily and gather more feedback, make improvements, etc... in the meantime! Thanks! |
Fixes #4194
Following the discussion we had on adding new features to
InAppNotificationControls
, I investigated the ability to replace the WCTInAppNotificationContol
by WinUI'sInfoBar
adding what is missing to it.PR Type
What is the current behavior?
Currently, there is 2 options to display in app notifications:
InAppNotificationControl
InfoBar
InAppNotificationControl
supports stacking whereasInfoBar
provides a better layout but does not have any advanced featuresWhat is the new behavior?
I'm proposing a new
StackedNotificationBehavior
to addInAppNotification
's behavior toInfoBar
.This new behavior handles:
Each notification can be triggered using a
Notification
object containing:The default control configuration will be used for all notifications.
This default configuration can be overriden per notification using
NotificationWithOverrides
. This allows a notification to alter any property from theInfoBar
control.PR Checklist
Please check if your PR fulfills the following requirements: