Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app domain unloading issue on .NET Framework #4386

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fix app domain unloading issue on .NET Framework #4386

merged 1 commit into from
Nov 18, 2021

Conversation

Sergio0694
Copy link
Member

Port of CommunityToolkit/dotnet@e2b3361.

Didn't really see any other commits already in https://github.com/CommunityToolkit/dotnet that would meet the hotfix bar for 7.1.2, so I think it's just this one hotfix we need on top of the other stuff that's already here on main, eg. the animation fix.

Fixes

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The app domain cannot be loaded on .NET Framework when using WeakReferenceMessenger.

What is the new behavior?

Auto trimming is disabled when running on .NET Framework, which solves the issue.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package hotfix 🌶 labels Nov 18, 2021
@ghost
Copy link

ghost commented Nov 18, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi November 18, 2021 11:41
@Sergio0694 Sergio0694 requested review from XAML-Knight and removed request for michael-hawker November 18, 2021 11:41
@Sergio0694 Sergio0694 merged commit 4a09bf0 into CommunityToolkit:main Nov 18, 2021
@Sergio0694 Sergio0694 deleted the feature/nct-712-changes branch November 18, 2021 18:22
@michael-hawker
Copy link
Member

Shipped as part of 7.1.2, I don't see our milestone for that though.

@michael-hawker michael-hawker added this to the 7.1.2 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAML-Knight XAML-Knight XAML-Knight approved these changes

@azchohfi azchohfi azchohfi approved these changes

Assignees
No one assigned
Labels
hotfix 🌶 mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package
Projects
None yet
Milestone
7.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Sergio0694 @michael-hawker @azchohfi @XAML-Knight