Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Radial Gauge ScaleTickBrush color assignment #4362

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

XamlBrewer
Copy link
Contributor

Due to a typo or a merge conflict, the ScaleTickBrush of the RadialGauge control currently gets the color of the ScaleBrush instead of its own.

Fixes

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The ScaleTickBrush property accidently gets its value from the ScaleBrush value in XAML or Resource Dictionary.

What is the new behavior?

The ScaleTickBrush gets its value from the corresponding XAML setting or Resource Dictionary.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x] Tested code with current supported SDKs
  • [ x] Contains NO breaking changes

Other information

Due to a typo or a merge conflict, the ScaleTickBrush of the RadialGauge control currently gets the color of the ScaleBrush instead of its own.
@ghost
Copy link

ghost commented Nov 2, 2021

Thanks XamlBrewer for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi November 2, 2021 19:10
@michael-hawker michael-hawker added this to the 7.2/8.0? milestone Nov 2, 2021
@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ labels Nov 2, 2021
Copy link
Contributor

@XAML-Knight XAML-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved - nice catch.

@XAML-Knight XAML-Knight merged commit 56d1b46 into CommunityToolkit:main Nov 2, 2021
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
@michael-hawker michael-hawker modified the milestones: 7.1.3, 7.1.2 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ hotfix 🌶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants