Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AccessibilityView in MetadataControl #4328

Conversation

lyf6lyf
Copy link
Contributor

@lyf6lyf lyf6lyf commented Oct 19, 2021

Fixes #4433

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

We can not change the AutomationProperties.AccessibilityView of the inner TextBlock of the MetadataControl, that causes some accessibility issue.

What is the new behavior?

We can change it by setting AutomationProperties.AccessibilityView of the MetadataControl

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Oct 19, 2021

Thanks lyf6lyf for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi October 19, 2021 05:21
@XAML-Knight
Copy link
Contributor

Try kicking off the CI build process again, to see if a 2nd try gets the unit tests to pass. I was able to get the unit tests to pass after a second pass, on my dev machine.

@michael-hawker michael-hawker added the partner ⏹ Label for issues that are being depended on or blocking Toolkit partners. label Dec 2, 2021
@michael-hawker
Copy link
Member

@vgromfeld want to take a look?

@michael-hawker michael-hawker added this to the 8.0 milestone Dec 16, 2021
@ghost ghost added accessibility ♿ bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ labels Dec 16, 2021
@michael-hawker michael-hawker merged commit 7bca4f8 into CommunityToolkit:main Dec 16, 2021
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ♿ bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ partner ⏹ Label for issues that are being depended on or blocking Toolkit partners.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessibilityView for MetadataControl
5 participants