Fix Missing Resources Exception leading to VS Designer crash #4310
Conversation
It just takes up too much space in the DLL's size.
The "EmbeddedResourceUseDependentUponConvention" does not automatically nest the generated sources to its parent files.
This leads to embedded resources being not found and the VS Designer crashes
Since, we only use the same Root Namespace for all controls, we don't need to specify them.
|
Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
bug 🐛
Nirmal4G
force-pushed
the
hotfix/design-tools
branch
5 times, most recently
from
92cb60f to
c5d4a5b
Compare
|
@michael-hawker All done. The Designer no longer crashes for me in both VS16 and VS17 IDEs. Can you check and confirm? |
There was a problem hiding this comment.
Tested with the Layout package in a VS 2019 file new project. Was failing with 7.1, updated package and worked great. Thanks @Nirmal4G for figuring this out! 🦙❤
@XAML-Knight want to test this out with another package or two on your side? I didn't check about hot reload failing with 7.1, but was working fine with the new layout package.
|
Bug fix confirmed. Was only able to repro XAML Hot reload VS crash once (VS 2019, 16.11.3, x86).
|
Fixes #4279
In addition to fixing the incorrect
RootNamespace, Icon naming is simplified andEmbeddedResourceitems will now properly nest the generated sources.See individual commit info more details.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
VS Designer crashes due to missing resources. The actual problem is that the
RootNamespaceis wrong and it generates incorrect manifest. This leads to missing resources whenResourceManagertries to resolve the embedded files.What is the new behavior?
Fixed the Namespace to use correct the
RootNamspaceboth in sources and in project files.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
rebaseon latestHEADand then commit, without updating from the latestHEAD.Merge pull request #xxxx from repo/branch, and commit message to either PR message or messages of individual commits. Theauto-mergebot does this by default.